Patchwork ARM: mx28: add dma channels for all auarts

login
register
mail settings
Submitter Eric Benard
Date April 19, 2013, 3:05 p.m.
Message ID <1366383906-25747-1-git-send-email-eric@eukrea.com>
Download mbox | patch
Permalink /patch/238025/
State New
Headers show

Comments

Eric Benard - April 19, 2013, 3:05 p.m.
Only auart0 was filled.
Tested on a custom i.MX283 board for ttyAPP1/2/3/4.

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 arch/arm/boot/dts/imx28.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
Fabio Estevam - April 19, 2013, 3:26 p.m.
Hi Eric,

On Fri, Apr 19, 2013 at 12:05 PM, Eric Bénard <eric@eukrea.com> wrote:
> Only auart0 was filled.
> Tested on a custom i.MX283 board for ttyAPP1/2/3/4.
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
>  arch/arm/boot/dts/imx28.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index 25f2243..15933ed 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -886,6 +886,7 @@
>                                 compatible = "fsl,imx28-auart", "fsl,imx23-auart";
>                                 reg = <0x8006c000 0x2000>;
>                                 interrupts = <113 72 73>;
> +                               fsl,auart-dma-channel = <10 11>;

Now we use the generic 'dmas' binding to passing such information.

If you look at linux-next tree these UART dma channels are already
been passed via the new 'dmas' method:

			auart1: serial@8006c000 {
				compatible = "fsl,imx28-auart", "fsl,imx23-auart";
				reg = <0x8006c000 0x2000>;
				interrupts = <113 72 73>;
				dmas = <&dma_apbx 10>, <&dma_apbx 11>;
				dma-names = "rx", "tx";
				clocks = <&clks 45>;
				status = "disabled";
			};
Eric Benard - April 19, 2013, 4:11 p.m.
Hi Fabio,

Le Fri, 19 Apr 2013 12:26:33 -0300,
Fabio Estevam <festevam@gmail.com> a écrit :
> On Fri, Apr 19, 2013 at 12:05 PM, Eric Bénard <eric@eukrea.com> wrote:
> > Only auart0 was filled.
> > Tested on a custom i.MX283 board for ttyAPP1/2/3/4.
> >
> > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > ---
> >  arch/arm/boot/dts/imx28.dtsi | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> > index 25f2243..15933ed 100644
> > --- a/arch/arm/boot/dts/imx28.dtsi
> > +++ b/arch/arm/boot/dts/imx28.dtsi
> > @@ -886,6 +886,7 @@
> >                                 compatible = "fsl,imx28-auart", "fsl,imx23-auart";
> >                                 reg = <0x8006c000 0x2000>;
> >                                 interrupts = <113 72 73>;
> > +                               fsl,auart-dma-channel = <10 11>;
> 
> Now we use the generic 'dmas' binding to passing such information.
> 
> If you look at linux-next tree these UART dma channels are already
> been passed via the new 'dmas' method:
> 
> 			auart1: serial@8006c000 {
> 				compatible = "fsl,imx28-auart", "fsl,imx23-auart";
> 				reg = <0x8006c000 0x2000>;
> 				interrupts = <113 72 73>;
> 				dmas = <&dma_apbx 10>, <&dma_apbx 11>;
> 				dma-names = "rx", "tx";
> 				clocks = <&clks 45>;
> 				status = "disabled";
> 			};

OK so forget my patch it was against 3.9-rc

Eric

Patch

diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 25f2243..15933ed 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -886,6 +886,7 @@ 
 				compatible = "fsl,imx28-auart", "fsl,imx23-auart";
 				reg = <0x8006c000 0x2000>;
 				interrupts = <113 72 73>;
+				fsl,auart-dma-channel = <10 11>;
 				clocks = <&clks 45>;
 				status = "disabled";
 			};
@@ -894,6 +895,7 @@ 
 				compatible = "fsl,imx28-auart", "fsl,imx23-auart";
 				reg = <0x8006e000 0x2000>;
 				interrupts = <114 74 75>;
+				fsl,auart-dma-channel = <12 13>;
 				clocks = <&clks 45>;
 				status = "disabled";
 			};
@@ -902,6 +904,7 @@ 
 				compatible = "fsl,imx28-auart", "fsl,imx23-auart";
 				reg = <0x80070000 0x2000>;
 				interrupts = <115 76 77>;
+				fsl,auart-dma-channel = <14 15>;
 				clocks = <&clks 45>;
 				status = "disabled";
 			};
@@ -910,6 +913,7 @@ 
 				compatible = "fsl,imx28-auart", "fsl,imx23-auart";
 				reg = <0x80072000 0x2000>;
 				interrupts = <116 78 79>;
+				fsl,auart-dma-channel = <0 1>;
 				clocks = <&clks 45>;
 				status = "disabled";
 			};