From patchwork Fri Apr 19 09:38:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Gautam X-Patchwork-Id: 237893 X-Patchwork-Delegate: marek.vasut@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 8151A2C007A for ; Fri, 19 Apr 2013 19:40:12 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1DE444A395; Fri, 19 Apr 2013 11:40:11 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YCCJa4PEf4Kh; Fri, 19 Apr 2013 11:40:10 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2F2C64A36C; Fri, 19 Apr 2013 11:40:09 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id F124A4A36C for ; Fri, 19 Apr 2013 11:40:07 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fRSDbhzgICju for ; Fri, 19 Apr 2013 11:40:06 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by theia.denx.de (Postfix) with ESMTP id 5B6D74A1CA for ; Fri, 19 Apr 2013 11:40:04 +0200 (CEST) Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MLH00HB3XII3AV0@mailout2.samsung.com> for u-boot@lists.denx.de; Fri, 19 Apr 2013 18:40:01 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.125]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id DB.7F.07735.1F011715; Fri, 19 Apr 2013 18:40:01 +0900 (KST) X-AuditID: cbfee68e-b7f946d000001e37-27-517110f11195 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 6F.13.17838.1F011715; Fri, 19 Apr 2013 18:40:01 +0900 (KST) Received: from vivekkumarg-linuxpc.sisodomain.com ([107.108.214.169]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MLH006COXIJMZ50@mmp1.samsung.com>; Fri, 19 Apr 2013 18:40:01 +0900 (KST) From: Vivek Gautam To: u-boot@lists.denx.de, marex@denx.de Date: Fri, 19 Apr 2013 15:08:20 +0530 Message-id: <1366364300-20988-1-git-send-email-gautam.vivek@samsung.com> X-Mailer: git-send-email 1.7.6.5 In-reply-to: <201304141911.45060.marex@denx.de> References: <201304141911.45060.marex@denx.de> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRmVeSWpSXmKPExsWyRsSkVvejQGGgwdGp8hZv2hoZLaYc/sJi 0bL2AKvF8tcb2S3e7u1kd2D1mDfrBIvHgk2lHneu7WHzOHtnB6NH35ZVjAGsUVw2Kak5mWWp Rfp2CVwZP5sWsxYc56z4vH8qSwPjXvYuRk4OCQETiTlnTjNC2GISF+6tZ+ti5OIQEljKKDHt +G4WmKKZy05AJRYxSvy5u4cRwpnCJPHh3F1WkCo2AV2Jpre7wEaJCKhL/D/cC2YzC3hJHG46 xAZiCws4SKybshtsNYuAqsSjfUvB4rwCHhLLr/VCnaQg8eb2M2YQm1NAX2LB9B4mEFtIQE9i +ZE/bBA17ewSbTurIOYISHybfAjoUg6guKzEpgPMECWSEgdX3GCZwCi8gJFhFaNoakFyQXFS epGRXnFibnFpXrpecn7uJkZgSJ/+96xvB+PNA9aHGJOBxk1klhJNzgfGRF5JvKGxmZGFqYmp sZG5pRlpwkrivGot1oFCAumJJanZqakFqUXxRaU5qcWHGJk4OKUaGH1spryTdKsssimIlrol YbQ/hLenrzBCRJ05JmnhRce/2xbWfS/W5losEGjt7+kWs3Nm5R49vaaKVe+8eLV3cHV16iSc 2p2/b4q9xIll0e7XFabUvD1y4tjjZayHnz3hY7+uE7g8x8hAoOvmxZxvJmayPH2bJ1WdFPRo 9tmwIk9/e5/Qb+NGJZbijERDLeai4kQArta/QH8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsVy+t9jAd2PAoWBBv3rxCzetDUyWkw5/IXF omXtAVaL5a83slu83dvJ7sDqMW/WCRaPBZtKPe5c28PmcfbODkaPvi2rGANYoxoYbTJSE1NS ixRS85LzUzLz0m2VvIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTdMnOAtisplCXmlAKFAhKL i5X07TBNCA1x07WAaYzQ9Q0JgusxMkADCWsYM342LWYtOM5Z8Xn/VJYGxr3sXYycHBICJhIz l51gg7DFJC7cWw9kc3EICSxilPhzdw8jhDOFSeLDubusIFVsAroSTW93MYLYIgLqEv8P94LZ zAJeEoebDoFNEhZwkFg3ZTfYBhYBVYlH+5aCxXkFPCSWX+uF2qwg8eb2M2YQm1NAX2LB9B4m EFtIQE9i+ZE/bBMYeRcwMqxiFE0tSC4oTkrPNdQrTswtLs1L10vOz93ECI6ZZ1I7GFc2WBxi FOBgVOLhbZAoCBRiTSwrrsw9xCjBwawkwjs9CSjEm5JYWZValB9fVJqTWnyIMRnoqonMUqLJ +cB4ziuJNzQ2MTc1NrU0sTAxsyRNWEmc90CrdaCQQHpiSWp2ampBahHMFiYOTqkGRrt2Rdbq K/UtYs9XaV6xklsT860hq+DTpQ83bk61OnQxd8OGkvY4XY+Hyo2p0YurV3NenNPCbu81N+dk nNztwqBmhv9sW2d5O14580Tx90om87y87h6b0wVzzgcmMEyc/JtTpsm+30tS99Jjcd3Wp3vv TZmhuZs5fk9HlMKCSVzeO0R9yswMlFiKMxINtZiLihMB5bpBW90CAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: u-boot-review@google.com, rajeshwari.s@samsung.com, patches@linaro.org Subject: [U-Boot] [PATCH] usb: common: Use a global definition for 'min3' X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de We can use a common global method for calculating minimum of 3 numbers. Put the same in 'common header' and let 'ehci' use it. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-hcd.c | 10 ---------- include/common.h | 5 +++++ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index 19d4352..e0f3e4b 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -603,16 +603,6 @@ fail: return -1; } -static inline int min3(int a, int b, int c) -{ - - if (b < a) - a = b; - if (c < a) - a = c; - return a; -} - int ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer, int length, struct devrequest *req) diff --git a/include/common.h b/include/common.h index 0cfa6a8..611edca 100644 --- a/include/common.h +++ b/include/common.h @@ -211,6 +211,11 @@ typedef void (interrupt_handler_t)(void *); #define MIN(x, y) min(x, y) #define MAX(x, y) max(x, y) +static inline int min3(int a, int b, int c) +{ + return min(min(a, b), c); +} + /* * Return the absolute value of a number. *