From patchwork Fri Apr 19 02:29:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: majianpeng X-Patchwork-Id: 237820 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5FEBC2C0209 for ; Fri, 19 Apr 2013 12:30:08 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967823Ab3DSC3o (ORCPT ); Thu, 18 Apr 2013 22:29:44 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:42307 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967782Ab3DSC3m (ORCPT ); Thu, 18 Apr 2013 22:29:42 -0400 Received: by mail-pa0-f42.google.com with SMTP id kq13so1977210pab.15 for ; Thu, 18 Apr 2013 19:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:content-type:content-transfer-encoding; bh=wyQfD62VW+Rdd8G/xhN5ocvpWGropMz5zo1jzXWBWKo=; b=JCFbO5M9ZZhHsQPAjRIZPWjGEySwEdPSBTM4QGpjiLfgWhbuld8U+nGdBGY6s7ap+R fhnOb/OM9gG4+SjL/NXKMG6yNrg3VZLHaEbTpcdy6iMcXgDvzmGA/Cl6EGlbSuIc4Ozb 7cYk5YvLIPM5gtM4fOvysbPR5Hw2BjMmSL88hBWygmESZDAxeVJ0DxRSfTtrx4dJAgQt 7LV+163nbO43quUnutcWelINYhcEm9hrT3HuM7o7WlPxrXLatyRGiA1PSm+AKqTTb0bQ eTY/vD/wCFPmZHD6Tz3+qc5EY/recr4+B8zkcBQXMJEKUnxb/e6WW7xUSXWztDXRXIj2 /q2Q== X-Received: by 10.68.108.196 with SMTP id hm4mr16260688pbb.88.1366338582235; Thu, 18 Apr 2013 19:29:42 -0700 (PDT) Received: from [172.16.193.108] ([218.242.10.181]) by mx.google.com with ESMTPS id o7sm11593580pbs.45.2013.04.18.19.29.37 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 18 Apr 2013 19:29:41 -0700 (PDT) Message-ID: <5170AC10.60504@gmail.com> Date: Fri, 19 Apr 2013 10:29:36 +0800 From: majianpeng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Al Viro , akpm@linux-foundation.org, tytso@mit.edu CC: linux-fsdevel , linux-kernel , linux-ext4@vger.kernel.org Subject: [PATCH] fs/buffer.c: Remove the unnecessary init operation after allocating buffer_head. Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Because alloc struct buffer_head using kmem_cache_zalloc,so it's not need to call 'init_buffer(bh, NULL, NULL)'. Signed-off-by: Jianpeng Ma --- fs/buffer.c | 2 -- fs/jbd/journal.c | 1 - fs/jbd2/journal.c | 1 - 3 files changed, 4 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index b4dcb34..52b7739 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -865,8 +865,6 @@ try_again: /* Link the buffer to its page */ set_bh_page(bh, page, offset); - - init_buffer(bh, NULL, NULL); } return head; /* diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c index 81cc7ea..0c3fe90 100644 --- a/fs/jbd/journal.c +++ b/fs/jbd/journal.c @@ -311,7 +311,6 @@ int journal_write_metadata_buffer(transaction_t *transaction, new_bh = alloc_buffer_head(GFP_NOFS|__GFP_NOFAIL); /* keep subsequent assertions sane */ new_bh->b_state = 0; - init_buffer(new_bh, NULL, NULL); atomic_set(&new_bh->b_count, 1); new_jh = journal_add_journal_head(new_bh); /* This sleeps */ diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index ed10991..95120c6 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -368,7 +368,6 @@ retry_alloc: /* keep subsequent assertions sane */ new_bh->b_state = 0; - init_buffer(new_bh, NULL, NULL); atomic_set(&new_bh->b_count, 1); new_jh = jbd2_journal_add_journal_head(new_bh); /* This sleeps */