From patchwork Fri Apr 19 02:12:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Crosthwaite X-Patchwork-Id: 237815 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1CEFF2C020F for ; Fri, 19 Apr 2013 12:14:41 +1000 (EST) Received: from localhost ([::1]:59745 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UT0qV-0000Ze-9A for incoming@patchwork.ozlabs.org; Thu, 18 Apr 2013 22:14:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UT0q8-0000Y3-Mt for qemu-devel@nongnu.org; Thu, 18 Apr 2013 22:14:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UT0q6-0005DF-MK for qemu-devel@nongnu.org; Thu, 18 Apr 2013 22:14:16 -0400 Received: from mail-da0-x22a.google.com ([2607:f8b0:400e:c00::22a]:40323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UT0q6-0005D5-Fv for qemu-devel@nongnu.org; Thu, 18 Apr 2013 22:14:14 -0400 Received: by mail-da0-f42.google.com with SMTP id n15so1226509dad.1 for ; Thu, 18 Apr 2013 19:14:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=32XNcAEOPoq64Ou9Q8hp6I47ZSrpH4SX8d/t7V8TGkM=; b=dFqn2C8iR2OUI4ZBKnIlnkhBpMFdXiPByZqtmEQqhjjNm+TlApZA+L6/JYEpESnxjc 3yQ3d0nYPvKyvrD+Lh8EFz4uJc0Dy2mNErBDRoD/e4AU/6MIhKE+rY1mtRs/rCDKT4dl LfAxx52OhmGMFEpSGBrAMYEU9x2RYu0BRx03kppLda8E046u/Si6a9+iAAIvEe48feU+ gmA74y1OGJGO0QuzaMNNiWs86LTfLkRSBAmScdsxDzFu8nkoOs1VWPAJtGF2VVK7giSO zUyPAEQRjNB1ljPLVaPF+TVLEEMAmU35oFcU6r150/K3XKIORlnCFaIGgXfRi32h5ZDf Zuow== X-Received: by 10.66.9.7 with SMTP id v7mr2898142paa.216.1366337653857; Thu, 18 Apr 2013 19:14:13 -0700 (PDT) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPS id j13sm12796300pat.17.2013.04.18.19.14.11 (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Thu, 18 Apr 2013 19:14:12 -0700 (PDT) From: peter.crosthwaite@xilinx.com To: qemu-devel@nongnu.org Date: Fri, 19 Apr 2013 12:12:09 +1000 Message-Id: <1a58a563c151ad944a140eb751adac335041ec45.1366335998.git.peter.crosthwaite@xilinx.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: References: X-Gm-Message-State: ALoCoQm0+NRI3CX6ErWK7KLByaK6/XlbL2Jq60P78ml08S8n2Kz4ON/Okrwsmnaa1s+B+4I7wYmM X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c00::22a Cc: peter.maydell@linaro.org Subject: [Qemu-devel] [PATCH for-1.5 v2 14/15] xilinx_spips: lqspi: Push more data to tx-fifo X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Peter Crosthwaite Do 16 words per fifo flush. Increases performance and decreases debug verbosity. This data depth has no real hardware analogue, so just go with something that has reasonable performance. Signed-off-by: Peter Crosthwaite --- hw/ssi/xilinx_spips.c | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index df55ca6..68434f0 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -609,11 +609,14 @@ lqspi_read(void *opaque, hwaddr addr, unsigned int size) DB_PRINT_L(0, "starting QSPI data read\n"); - for (i = 0; i < LQSPI_CACHE_SIZE / 4; ++i) { - tx_data_bytes(s, 0, 4); + while (cache_entry < LQSPI_CACHE_SIZE / 4) { + for (i = 0; i < 16; ++i) { + tx_data_bytes(s, 0, 4); + } xilinx_spips_flush_txfifo(s); - rx_data_bytes(s, &q->lqspi_buf[cache_entry], 4); - cache_entry++; + for (i = 0; i < 16; ++i) { + rx_data_bytes(s, &q->lqspi_buf[cache_entry++], 4); + } } s->regs[R_LQSPI_STS] &= ~LQSPI_CFG_U_PAGE;