Patchwork I2C: Change the value of octeon i2c adapter timeout value

login
register
mail settings
Submitter 송은봉
Date April 19, 2013, 12:01 a.m.
Message ID <22387590.3491366329664571.JavaMail.weblogic@epv6ml11>
Download mbox | patch
Permalink /patch/237774/
State Accepted
Headers show

Comments

송은봉 - April 19, 2013, 12:01 a.m.
I think HZ/50 is better than 2 for adapter timeout.

Signed-off-by: Eunbong Song <eunb.song@samsung.com>

---
 drivers/i2c/busses/i2c-octeon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

-- 
1.7.0.1
Wolfram Sang - April 19, 2013, 7:58 a.m.
On Fri, Apr 19, 2013 at 12:01:04AM +0000, EUNBONG SONG wrote:
> 
> I think HZ/50 is better than 2 for adapter timeout.

Basically OK. But why HZ/50? Most drivers use HZ.

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c

index 935585e..ca489f3 100644

--- a/drivers/i2c/busses/i2c-octeon.c

+++ b/drivers/i2c/busses/i2c-octeon.c

@@ -440,7 +440,7 @@  static struct i2c_adapter octeon_i2c_ops = {

 	.owner = THIS_MODULE,
 	.name = "OCTEON adapter",
 	.algo = &octeon_i2c_algo,
-	.timeout = 2,

+	.timeout = HZ/50,

 };
 
 /**