From patchwork Thu Apr 18 22:05:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cary Coutant X-Patchwork-Id: 237751 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 8910E2C0207 for ; Fri, 19 Apr 2013 08:05:36 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:content-type; q= dns; s=default; b=tRw4tJEoqy8prAAvv9LDtOhk1HsSoSHLntYT4KuBdz908C E7bhMevWUsEimLg9qNY6wTXfhLtjvhXriVdTG+LomkAEaqHyzxBOv1lGLo1bwLyM w3xE67LcslD4x4tNtJm9WcuqjCfFgP9QxvmMVCSszj2SzjESBkwUgFAiKYLks= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:content-type; s= default; bh=zjJU1C7K1sY3S613Nzj5ycvTQUo=; b=yz+Q+3YQR+RtabA8gYCs RdqeyjBB22NcTGuj59Z8oq2xUslJZIxMB8qOtR0844mqYNDoI7BQjoCwRWZZx72J 9OFiJffcEC4zCp0TME/LbwLFlpoaw8oeAzVsqWn/UOg9ooaRT0iWOlVfbY5e13We d3IWTlWt3c1jf8uFR7CGLAI= Received: (qmail 2485 invoked by alias); 18 Apr 2013 22:05:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 2471 invoked by uid 89); 18 Apr 2013 22:05:29 -0000 X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mail-pd0-f175.google.com (HELO mail-pd0-f175.google.com) (209.85.192.175) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 18 Apr 2013 22:05:28 +0000 Received: by mail-pd0-f175.google.com with SMTP id g10so1808981pdj.6 for ; Thu, 18 Apr 2013 15:05:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to :content-type:x-gm-message-state; bh=3X5xxz73BZ2UE0gqLApiQN/zDPVWTXH3cFBu/DMLmho=; b=OkKUYjdTp2lKSTt6n9UCBeDrVLX4nCxZsqAL6rmSz+dYIxHxc0/OSIa89YmCirKL8+ luUsY4F6cIYXbD6FNYH6simlXnAvSAMfbOU9+i9M2qD1no8NNnWr9ho8IEjzh2sb3IEv wRtJHgE94djG5toOxZxnt2fYAcKSnDYHO1lGK0JSfEsCvGEkTZbsVKslcGFiC2yVzoC6 CVRRquhQyugXAWw94kiG28F64AXAMel1VnzV792vOlgf7DG1L92gBFy5wCkGZqILBQPX piInhXpFUci+iRBGiPwEQzJTnR2M/4duQIhBFp6uooWu6RbTXL8q08IzZbi64/WKFJ1M 7vKQ== MIME-Version: 1.0 X-Received: by 10.67.5.168 with SMTP id cn8mr2235688pad.119.1366322726914; Thu, 18 Apr 2013 15:05:26 -0700 (PDT) Received: by 10.68.242.70 with HTTP; Thu, 18 Apr 2013 15:05:26 -0700 (PDT) Date: Thu, 18 Apr 2013 15:05:26 -0700 Message-ID: Subject: [patch rfa] Fix PCH test failure when -fdebug-types-section is enabled From: Cary Coutant To: gcc-patches X-Gm-Message-State: ALoCoQmIW6xkhEqdExA+HrsgH9+/gFm1CA5izQsJS/ksL2dsHxbYz3zfwXopdNjOc68nTjSn2lt7tvUoyqWBaoWHYm7sXvt8fcvm9tkLR11On3reih8frgtXMHsMEVpQMllaVf3CnscauRoCOXNutIHiOJDc/wm3IRCw+2cUXK8EAa/4r6/eE//DHNM1ED+2qyTHeaKO7n5E If I turn on -fdebug-types-section, I get a failure in the PCH tests: FAIL: g++.dg/pch/system-2.C -O2 -g assembly comparison This appears to be the result of differences in hash table traversal during debug output (same output, slightly different order), so I'm thinking it's just luck that it works under the default conditions. The following patch fixes the problem, simply by forcing -fno-debug-types-section for all PCH tests, but I see no fundamental reason why that should be necessary. If anyone has any advice for how to solve the underlying problem, I'd appreciate it. -cary } Index: lib/dg-pch.exp =================================================================== --- lib/dg-pch.exp (revision 198068) +++ lib/dg-pch.exp (working copy) @@ -139,5 +139,5 @@ proc dg-flags-pch { subdir test otherfla } proc dg-pch { subdir test options suffix } { - return [dg-flags-pch $subdir $test "" $options $suffix] + return [dg-flags-pch $subdir $test "-fno-debug-types-section" $options $suffix]