Patchwork [U-Boot,v3,0/8] usb: ss: Some fixes and cleanup for USB super-speed support

login
register
mail settings
Submitter Marek Vasut
Date April 18, 2013, 12:43 p.m.
Message ID <201304181443.36677.marex@denx.de>
Download mbox | patch
Permalink /patch/237634/
State Superseded
Delegated to: Marek Vasut
Headers show

Comments

Marek Vasut - April 18, 2013, 12:43 p.m.
Dear Vivek Gautam,

> HI Marek,
> 
> On Thu, Apr 18, 2013 at 4:29 PM, Vivek Gautam <gautamvivek1987@gmail.com> 
wrote:
> > On Thu, Apr 18, 2013 at 11:54 AM, Vivek Gautam
> > 
> > <gautamvivek1987@gmail.com> wrote:
> >> Hi Marek,
> >> 
> >> On Sun, Apr 14, 2013 at 11:43 PM, Marek Vasut <marex@denx.de> wrote:
> >>> Dear Vivek Gautam,
> >>> 
> >>>> Based on 'u-boot-usb' master branch.
> >>>> 
> >>>> This patch-series includes majorly some clean-up, few fixes and
> >>>> then some basic super-speed usb infrastructure addition, to help
> >>>> put support for XHCI in near future.
> >>> 
> >>> btw can you test your patches with MAKEALL -a arm? I get this:
> >>> 
> >>> --------------------- SUMMARY ----------------------------
> >>> Boards compiled: 306
> >>> Boards with errors: 65 ( qong mx35pdk gplugd at91sam9m10g45ek_nandflash
> >>> pogo_e02 dns325 iconnect lschlv2 lsxhl d2net_v2 inetspace_v2
> >>> net2big_v2 netspace_lite_v2 netspace_max_v2 netspace_v2 wireless_space
> >>> dreamplug guruplug mv88f6281gtw_ge openrd_base openrd_client
> >>> openrd_ultimate rd6281a sheevaplug ib62x0 dockstar tk71 zmx25
> >>> mx23_olinuxino apx4devkit mx23evk m28evk mx28evk sc_sps_1 edminiv2
> >>> mx51_efikamx mx51_efikasb mx51evk mx53loco mx6qsabreauto mx6qsabrelite
> >>> nitrogen6dl nitrogen6dl2g nitrogen6q nitrogen6q2g nitrogen6s
> >>> nitrogen6s1g cm_t35 mt_ventoux omap3_beagle mcx twister omap4_panda
> >>> snow smdk5250 harmony seaboard ventana whistler colibri_t20_iris
> >>> plutux medcom-wide tec paz00 trimslice )
> >>> ----------------------------------------------------------
> >> 
> >> Tried with MAKEALL
> >> got following result
> >> 
> >> --------------------- SUMMARY ----------------------------
> >> Boards compiled: 306
> >> Boards with errors: 1 ( omap3_evm )
> >> Boards with warnings but no errors: 17 ( VCMA9 smdk2410 kzm9g balloon3
> >> h2200 lubbock palmld palmtc polaris pxa255_idp trizepsiv
> >> vpac270_nor_128 vpac270_nor_256 vpac270_ond_256 xaeniax zipitz2
> >> colibri_pxa270 )
> >> ----------------------------------------------------------
> 
> I actually checked now just for omap3_evm configuration by trying out:
>       make distclean
>       make omap3_evm_config
>       make
> 
> But strangely i didn't get any build errros for omap3_evm board on
> explicitly compiling for it.
> Any clue ?
> 
> > **Without my patches i get following result
> > 
> > --------------------- SUMMARY ----------------------------
> > Boards compiled: 306
> > Boards with warnings but no errors: 17 ( VCMA9 smdk2410 kzm9g balloon3
> > h2200 lubbock palmld palmtc polaris pxa255_idp trizepsiv
> > vpac270_nor_128 vpac270_nor_256 vpac270_ond_256 xaeniax zipitz2
> > colibri_pxa270 )
> > ----------------------------------------------------------
> > 
> >> There's something to do with Cross Compiler version ??
> >> btw what environment are you compiling the source with.
> 
> I am using "arm-2011.09" cross toolchain.

I use ELDK 5.3 and Debian 4.7.2-5 to do by builds. But now that I'm looking at 
it, it's this patch that caused it, sorry.

commit 28b31a5937b89528c40df24dd6c9122578880605
Author: Julius Werner <jwerner@chromium.org>
Date:   Thu Feb 28 18:08:40 2013 +0000

    usb: Add new command to set USB 2.0 port test modes

        debug("req=%u (%#x), type=%u (%#x), value=%u, index=%u\n",

This change fixes is, right Julius ?

Best regards,
Marek Vasut
Julius Werner - April 18, 2013, 5:11 p.m.
Hi Marek,

I'm sorry, that must have slipped by when I ported the change from my
local fork. Your patch is correct, you just need to add the "ctrl->"
there.

On Thu, Apr 18, 2013 at 5:43 AM, Marek Vasut <marex@denx.de> wrote:
> Dear Vivek Gautam,
>
>> HI Marek,
>>
>> On Thu, Apr 18, 2013 at 4:29 PM, Vivek Gautam <gautamvivek1987@gmail.com>
> wrote:
>> > On Thu, Apr 18, 2013 at 11:54 AM, Vivek Gautam
>> >
>> > <gautamvivek1987@gmail.com> wrote:
>> >> Hi Marek,
>> >>
>> >> On Sun, Apr 14, 2013 at 11:43 PM, Marek Vasut <marex@denx.de> wrote:
>> >>> Dear Vivek Gautam,
>> >>>
>> >>>> Based on 'u-boot-usb' master branch.
>> >>>>
>> >>>> This patch-series includes majorly some clean-up, few fixes and
>> >>>> then some basic super-speed usb infrastructure addition, to help
>> >>>> put support for XHCI in near future.
>> >>>
>> >>> btw can you test your patches with MAKEALL -a arm? I get this:
>> >>>
>> >>> --------------------- SUMMARY ----------------------------
>> >>> Boards compiled: 306
>> >>> Boards with errors: 65 ( qong mx35pdk gplugd at91sam9m10g45ek_nandflash
>> >>> pogo_e02 dns325 iconnect lschlv2 lsxhl d2net_v2 inetspace_v2
>> >>> net2big_v2 netspace_lite_v2 netspace_max_v2 netspace_v2 wireless_space
>> >>> dreamplug guruplug mv88f6281gtw_ge openrd_base openrd_client
>> >>> openrd_ultimate rd6281a sheevaplug ib62x0 dockstar tk71 zmx25
>> >>> mx23_olinuxino apx4devkit mx23evk m28evk mx28evk sc_sps_1 edminiv2
>> >>> mx51_efikamx mx51_efikasb mx51evk mx53loco mx6qsabreauto mx6qsabrelite
>> >>> nitrogen6dl nitrogen6dl2g nitrogen6q nitrogen6q2g nitrogen6s
>> >>> nitrogen6s1g cm_t35 mt_ventoux omap3_beagle mcx twister omap4_panda
>> >>> snow smdk5250 harmony seaboard ventana whistler colibri_t20_iris
>> >>> plutux medcom-wide tec paz00 trimslice )
>> >>> ----------------------------------------------------------
>> >>
>> >> Tried with MAKEALL
>> >> got following result
>> >>
>> >> --------------------- SUMMARY ----------------------------
>> >> Boards compiled: 306
>> >> Boards with errors: 1 ( omap3_evm )
>> >> Boards with warnings but no errors: 17 ( VCMA9 smdk2410 kzm9g balloon3
>> >> h2200 lubbock palmld palmtc polaris pxa255_idp trizepsiv
>> >> vpac270_nor_128 vpac270_nor_256 vpac270_ond_256 xaeniax zipitz2
>> >> colibri_pxa270 )
>> >> ----------------------------------------------------------
>>
>> I actually checked now just for omap3_evm configuration by trying out:
>>       make distclean
>>       make omap3_evm_config
>>       make
>>
>> But strangely i didn't get any build errros for omap3_evm board on
>> explicitly compiling for it.
>> Any clue ?
>>
>> > **Without my patches i get following result
>> >
>> > --------------------- SUMMARY ----------------------------
>> > Boards compiled: 306
>> > Boards with warnings but no errors: 17 ( VCMA9 smdk2410 kzm9g balloon3
>> > h2200 lubbock palmld palmtc polaris pxa255_idp trizepsiv
>> > vpac270_nor_128 vpac270_nor_256 vpac270_ond_256 xaeniax zipitz2
>> > colibri_pxa270 )
>> > ----------------------------------------------------------
>> >
>> >> There's something to do with Cross Compiler version ??
>> >> btw what environment are you compiling the source with.
>>
>> I am using "arm-2011.09" cross toolchain.
>
> I use ELDK 5.3 and Debian 4.7.2-5 to do by builds. But now that I'm looking at
> it, it's this patch that caused it, sorry.
>
> commit 28b31a5937b89528c40df24dd6c9122578880605
> Author: Julius Werner <jwerner@chromium.org>
> Date:   Thu Feb 28 18:08:40 2013 +0000
>
>     usb: Add new command to set USB 2.0 port test modes
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 8464850..19d4352 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -630,7 +630,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe,
> void *buffer,
>                 printf("The request port(%d) is not configured\n", port - 1);
>                 return -1;
>         }
> -       status_reg = (uint32_t *)&hcor->or_portsc[port - 1];
> +       status_reg = (uint32_t *)&ctrl->hcor->or_portsc[port - 1];
>         srclen = 0;
>
>         debug("req=%u (%#x), type=%u (%#x), value=%u, index=%u\n",
>
> This change fixes is, right Julius ?
>
> Best regards,
> Marek Vasut
Marek Vasut - April 18, 2013, 7:15 p.m.
Hi Julius,

> Hi Marek,
> 
> I'm sorry, that must have slipped by when I ported the change from my
> local fork. Your patch is correct, you just need to add the "ctrl->"
> there.

Well, next time please make sure to compile-test your patches at least before 
you send them.

The stuff is now pushed, Vivek.

Best regards,
Marek Vasut
Vivek Gautam - April 19, 2013, 4:51 a.m.
On Fri, Apr 19, 2013 at 12:45 AM, Marek Vasut <marex@denx.de> wrote:
> Hi Julius,
>
>> Hi Marek,
>>
>> I'm sorry, that must have slipped by when I ported the change from my
>> local fork. Your patch is correct, you just need to add the "ctrl->"
>> there.
>
> Well, next time please make sure to compile-test your patches at least before
> you send them.
>
> The stuff is now pushed, Vivek.

Thanks Marek.

Patch

diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index 8464850..19d4352 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -630,7 +630,7 @@  ehci_submit_root(struct usb_device *dev, unsigned long pipe, 
void *buffer,
                printf("The request port(%d) is not configured\n", port - 1);
                return -1;
        }
-       status_reg = (uint32_t *)&hcor->or_portsc[port - 1];
+       status_reg = (uint32_t *)&ctrl->hcor->or_portsc[port - 1];
        srclen = 0;