From patchwork Thu Apr 18 11:47:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Zacarias X-Patchwork-Id: 237622 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id AFB022C015D for ; Thu, 18 Apr 2013 21:47:43 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id EDED38D3AB; Thu, 18 Apr 2013 11:47:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FOrwp1ar6yIW; Thu, 18 Apr 2013 11:47:35 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id A20578D3AC; Thu, 18 Apr 2013 11:47:34 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 933EE8F74B for ; Thu, 18 Apr 2013 11:47:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id DDC7D8D3AB for ; Thu, 18 Apr 2013 11:47:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pgsTUf1YjUek for ; Thu, 18 Apr 2013 11:47:30 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from loknar.toptech.com.ar (loknar.toptech.com.ar [78.46.79.162]) by whitealder.osuosl.org (Postfix) with ESMTPS id 25ADB8D3AC for ; Thu, 18 Apr 2013 11:47:29 +0000 (UTC) Received: from asgard (host63.190-30-133.telecom.net.ar [190.30.133.63]) (authenticated bits=0) by loknar.toptech.com.ar (8.14.6/8.14.6) with ESMTP id r3IBlMq7029326 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 18 Apr 2013 11:47:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=zacarias.com.ar; s=dkey; t=1366285647; bh=tb8SRBwOeDgLdxI4jQVSt2+U9iNR6W5aC6gha3B8IKc=; h=From:To:Cc:Subject:Date; b=Iqoy09/mw4jSAAQLPhHQyu0m3o7h9AYwQh9QESCIhyzETiYubK5PE2333RRpvTgRS 9dZeey65nCo82+Kw+Oe7xUlnstPMgq+BwcCOKFM7ikCNm/JYyCKDWAHTjcmz+Lb0tF KokWAaLxrcxT3kf8X/ok/c7e/bO/m5M0z8oykqCE= Received: by asgard (sSMTP sendmail emulation); Thu, 18 Apr 2013 08:47:21 -0300 From: Gustavo Zacarias To: buildroot@busybox.net Date: Thu, 18 Apr 2013 08:47:21 -0300 Message-Id: <1366285641-7018-1-git-send-email-gustavo@zacarias.com.ar> X-Mailer: git-send-email 1.8.1.5 X-Virus-Scanned: clamav-milter 0.97.7 at loknar X-Virus-Status: Clean Subject: [Buildroot] [PATCH] quagga: fix build breakage without snmp X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Quagga no longer supports explicitly disabling snmp, and what's worse, it interprets --disable-snmp as --enable-snmp. Remove the disable configure option. While at it add a comment about net-snmp requiring AgentX support for quagga to build properly as suggested by Arnout. Fixes: http://autobuild.buildroot.net/results/a9bce6dd8065ddb1850a4e14f0e4eb257ee89286/ Signed-off-by: Gustavo Zacarias --- package/quagga/Config.in | 3 +++ package/quagga/quagga.mk | 4 +--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/package/quagga/Config.in b/package/quagga/Config.in index 0834201..c364ae1 100644 --- a/package/quagga/Config.in +++ b/package/quagga/Config.in @@ -84,4 +84,7 @@ config BR2_PACKAGE_QUAGGA_SNMP help Make quagga information available via SNMP SMUX. +comment "AgentX support must be enabled in net-snmp or the build will break" + depends on BR2_PACKAGE_QUAGGA_SNMP + endif diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk index 42f8506..347ec4d 100644 --- a/package/quagga/quagga.mk +++ b/package/quagga/quagga.mk @@ -26,10 +26,8 @@ QUAGGA_CONF_OPT += $(if $(BR2_PACKAGE_QUAGGA_OPAQUE_LSA),--enable-opaque-lsa,--d ifeq ($(BR2_PACKAGE_QUAGGA_SNMP),y) QUAGGA_CONF_ENV += ac_cv_path_NETSNMP_CONFIG=$(STAGING_DIR)/usr/bin/net-snmp-config -QUAGGA_CONF_OPT += --enable-snmp +QUAGGA_CONF_OPT += --enable-snmp=agentx QUAGGA_DEPENDENCIES += netsnmp -else -QUAGGA_CONF_OPT +=--disable-snmp endif $(eval $(autotools-package))