| Submitter | Mike Frysinger |
|---|---|
| Date | Feb. 26, 2009, 8:30 a.m. |
| Message ID | <1235637006-28538-1-git-send-email-vapier@gentoo.org> |
| Download | mbox | patch |
| Permalink | /patch/23756/ |
| State | Accepted, archived |
| Headers | show |
Comments
On Thu, 2009-02-26 at 03:30 -0500, Mike Frysinger wrote: > Some compilers (like gcc-3.3) don't support all the newer -W flags that we > are using. So import the compiler check found in the kernel and test each > flag we add. The := is important so we only do the compiler tests once > per `make` rather than every time we compile a file. > > Signed-off-by: Mike Frysinger <vapier@gentoo.org> Pushed, thanks!
Patch
diff --git a/common.mk b/common.mk index 0e8c62b..5e92b07 100644 --- a/common.mk +++ b/common.mk @@ -1,8 +1,18 @@ CC := $(CROSS)gcc AR := $(CROSS)ar RANLIB := $(CROSS)ranlib + +# Stolen from Linux build system +try-run = $(shell set -e; ($(1)) >/dev/null 2>&1 && echo "$(2)" || echo "$(3)") +cc-option = $(call try-run, $(CC) $(1) -c -xc /dev/null -o /dev/null,$(1),$(2)) + CFLAGS ?= -O2 -g -CFLAGS += -Wall -Wextra -Wwrite-strings -Wno-sign-compare -D_FILE_OFFSET_BITS=64 +WFLAGS := -Wall \ + $(call cc-option,-Wextra) \ + $(call cc-option,-Wwrite-strings) \ + $(call cc-option,-Wno-sign-compare) +CFLAGS += $(WFLAGS) +CPPFLAGS += -D_FILE_OFFSET_BITS=64 DESTDIR ?= /usr/local PREFIX=/usr
Some compilers (like gcc-3.3) don't support all the newer -W flags that we are using. So import the compiler check found in the kernel and test each flag we add. The := is important so we only do the compiler tests once per `make` rather than every time we compile a file. Signed-off-by: Mike Frysinger <vapier@gentoo.org> --- v2 - remove debug code in try-run common.mk | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-)