| Message ID | 1366263235-7787-1-git-send-email-shangw@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Thu, 2013-04-18 at 13:33 +0800, Gavin Shan wrote: > The firmware should have supplied correct information for the kernel > to figure out the page size array, which is traced by mmu_psize_defs[]. > Otherwise, the kernel will fail back to use solely 4KB page size > and copy mmu_psize_defaults_old[] over to mmu_psize_defs[]. However, > the "tlbiel" isn't enabled in mmu_psize_defaults_old[]. Did you actually find a problem here ? There is a reason we don't enable tlbiel in there ... those old CPUs do not support it. Ben. > Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com> > --- > arch/powerpc/mm/hash_utils_64.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c > index 2d4a20c..8675ae5 100644 > --- a/arch/powerpc/mm/hash_utils_64.c > +++ b/arch/powerpc/mm/hash_utils_64.c > @@ -130,7 +130,7 @@ static struct mmu_psize_def mmu_psize_defaults_old[] = { > .sllp = 0, > .penc = 0, > .avpnm = 0, > - .tlbiel = 0, > + .tlbiel = 1, > }, > }; >
diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c index 2d4a20c..8675ae5 100644 --- a/arch/powerpc/mm/hash_utils_64.c +++ b/arch/powerpc/mm/hash_utils_64.c @@ -130,7 +130,7 @@ static struct mmu_psize_def mmu_psize_defaults_old[] = { .sllp = 0, .penc = 0, .avpnm = 0, - .tlbiel = 0, + .tlbiel = 1, }, };
The firmware should have supplied correct information for the kernel to figure out the page size array, which is traced by mmu_psize_defs[]. Otherwise, the kernel will fail back to use solely 4KB page size and copy mmu_psize_defaults_old[] over to mmu_psize_defs[]. However, the "tlbiel" isn't enabled in mmu_psize_defaults_old[]. Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com> --- arch/powerpc/mm/hash_utils_64.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)