Patchwork [3/3] kvm/ppc: don't call complete_mmio_load when it's a store

login
register
mail settings
Submitter Alexander Graf
Date April 17, 2013, 7:04 p.m.
Message ID <1366225447-24008-4-git-send-email-agraf@suse.de>
Download mbox | patch
Permalink /patch/237344/
State New
Headers show

Comments

Alexander Graf - April 17, 2013, 7:04 p.m.
From: Scott Wood <scottwood@freescale.com>

complete_mmio_load writes back the mmio result into the
destination register.  Doing this on a store results in
register corruption.

Signed-off-by: Scott Wood <scottwood@freescale.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 arch/powerpc/kvm/powerpc.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Patch

diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
index 16b4595..a822659 100644
--- a/arch/powerpc/kvm/powerpc.c
+++ b/arch/powerpc/kvm/powerpc.c
@@ -683,7 +683,6 @@  int kvmppc_handle_store(struct kvm_run *run, struct kvm_vcpu *vcpu,
 
 	if (!kvm_io_bus_write(vcpu->kvm, KVM_MMIO_BUS, run->mmio.phys_addr,
 			      bytes, &run->mmio.data)) {
-		kvmppc_complete_mmio_load(vcpu, run);
 		vcpu->mmio_needed = 0;
 		return EMULATE_DONE;
 	}