From patchwork Wed Apr 17 16:07:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 237273 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ia0-x240.google.com (mail-ia0-x240.google.com [IPv6:2607:f8b0:4001:c02::240]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id CBB9A2C0136 for ; Thu, 18 Apr 2013 02:07:33 +1000 (EST) Received: by mail-ia0-f192.google.com with SMTP id o25sf604303iad.29 for ; Wed, 17 Apr 2013 09:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-received :message-id:subject:from:to:cc:date:x-mailer:mime-version :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type; bh=eSuq2Gu02OVm/mNArpq/ftmXJ5Qcvre3Jzqz/GVqH38=; b=sGrMOEeg8ibXJX/UEESPJKkHVc+JRGC3pLgbfRJ6scEzpil0RLly9KG8MyRhIz6vK5 0V7u5mkz40Z3tA/W5VuRqR5HR6J9cHAtP3mZeVMSOJ3pqDshpmspmdX5wrGIdS6dul+W +uDZyIV/0dTEpRd5Xu2lmwWBou1o3wQkUXJoUGQpW9VCObxglRc+FqGrfi9NFBccTjqz 9kfa4tH4E27es+JG7J+7zheDd532YiEhWto+XYWQDcV6OHEAhiUj7lgVwCfA8MUdxsf2 LJ18paYk+sAjcgmSh/cLdfJNVL1RRkkYzbOJiXCzKUeGncvtSGNWG2M3bgUIOGSYwY3e nQNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-beenthere:x-received:received-spf:x-received :message-id:subject:from:to:cc:date:x-mailer:mime-version :x-gm-message-state:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=eSuq2Gu02OVm/mNArpq/ftmXJ5Qcvre3Jzqz/GVqH38=; b=T33syuFTAOPr1UOVKMa3shKzJolOnfPC8/iF9lMCOAtyOP0DKVb2PRcmg/kVJIX2mM naJDa8Mp4OLSrNNB8NvTo0gxqOlu+nzEkn3HmL4QeLpmGuL0aQ2FND9kx9e2BQNU/ZsG 8to4QkV5sXPl8XRS0Vp+uPYonEpbfdme5IP6wdOoKQetwb/4E0SN2ZWefMTL9eDaPSry t+zRsSPPjYScQL/ZDlIV1+21jJ3KbFoIXX0Lw+OE1W/CbG0fVANPbI0cR4/s5QpudBz8 I5O4kJEInnf1Tr4ZOeZjLySu1uQl67+AFx+Ubbg3VAsraxpPKwIJGt5mbCGzYdv7msBt 7hzQ== X-Received: by 10.50.180.197 with SMTP id dq5mr2631236igc.17.1366214848937; Wed, 17 Apr 2013 09:07:28 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.151.135 with SMTP id uq7ls3224941igb.24.canary; Wed, 17 Apr 2013 09:07:28 -0700 (PDT) X-Received: by 10.66.162.162 with SMTP id yb2mr509253pab.15.1366214848382; Wed, 17 Apr 2013 09:07:28 -0700 (PDT) Received: from mail-da0-x229.google.com (mail-da0-x229.google.com [2607:f8b0:400e:c00::229]) by gmr-mx.google.com with ESMTPS id xq5si966854pac.2.2013.04.17.09.07.28 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 17 Apr 2013 09:07:28 -0700 (PDT) Received-SPF: pass (google.com: domain of axel.lin@ingics.com designates 2607:f8b0:400e:c00::229 as permitted sender) client-ip=2607:f8b0:400e:c00::229; Received: by mail-da0-x229.google.com with SMTP id p8so720014dan.28 for ; Wed, 17 Apr 2013 09:07:28 -0700 (PDT) X-Received: by 10.66.159.234 with SMTP id xf10mr9475162pab.203.1366214847992; Wed, 17 Apr 2013 09:07:27 -0700 (PDT) Received: from [192.168.0.102] (111-255-127-123.dynamic.hinet.net. [111.255.127.123]) by mx.google.com with ESMTPS id dr6sm7607175pac.11.2013.04.17.09.07.25 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 17 Apr 2013 09:07:26 -0700 (PDT) Message-ID: <1366214842.22695.0.camel@phoenix> Subject: [rtc-linux] [PATCH] rtc: max6902: Use register defines instead of magic numbers From: Axel Lin To: Andrew Morton Cc: Raphael Assenat , Alessandro Zummo , rtc-linux@googlegroups.com Date: Thu, 18 Apr 2013 00:07:22 +0800 X-Mailer: Evolution 3.6.2-0ubuntu0.1 Mime-Version: 1.0 X-Gm-Message-State: ALoCoQk2Q5oDUxTD59Q6yGVa7bDMELwrqUVDT+hYcuwWefrRBRSnl6CQCMUlarD/FsdJ3Q/WPED+ X-Original-Sender: axel.lin@ingics.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of axel.lin@ingics.com designates 2607:f8b0:400e:c00::229 as permitted sender) smtp.mail=axel.lin@ingics.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Current code has defines for registers, use the defines rather than magic numbers. Signed-off-by: Axel Lin --- drivers/rtc/rtc-max6902.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/rtc/rtc-max6902.c b/drivers/rtc/rtc-max6902.c index 7730a65..e3aea00 100644 --- a/drivers/rtc/rtc-max6902.c +++ b/drivers/rtc/rtc-max6902.c @@ -93,24 +93,24 @@ static int max6902_set_time(struct device *dev, struct rtc_time *dt) dt->tm_year = dt->tm_year + 1900; /* Remove write protection */ - max6902_set_reg(dev, 0xF, 0); + max6902_set_reg(dev, MAX6902_REG_CONTROL, 0); - max6902_set_reg(dev, 0x01, bin2bcd(dt->tm_sec)); - max6902_set_reg(dev, 0x03, bin2bcd(dt->tm_min)); - max6902_set_reg(dev, 0x05, bin2bcd(dt->tm_hour)); + max6902_set_reg(dev, MAX6902_REG_SECONDS, bin2bcd(dt->tm_sec)); + max6902_set_reg(dev, MAX6902_REG_MINUTES, bin2bcd(dt->tm_min)); + max6902_set_reg(dev, MAX6902_REG_HOURS, bin2bcd(dt->tm_hour)); - max6902_set_reg(dev, 0x07, bin2bcd(dt->tm_mday)); - max6902_set_reg(dev, 0x09, bin2bcd(dt->tm_mon + 1)); - max6902_set_reg(dev, 0x0B, bin2bcd(dt->tm_wday)); - max6902_set_reg(dev, 0x0D, bin2bcd(dt->tm_year % 100)); - max6902_set_reg(dev, 0x13, bin2bcd(dt->tm_year / 100)); + max6902_set_reg(dev, MAX6902_REG_DATE, bin2bcd(dt->tm_mday)); + max6902_set_reg(dev, MAX6902_REG_MONTH, bin2bcd(dt->tm_mon + 1)); + max6902_set_reg(dev, MAX6902_REG_DAY, bin2bcd(dt->tm_wday)); + max6902_set_reg(dev, MAX6902_REG_YEAR, bin2bcd(dt->tm_year % 100)); + max6902_set_reg(dev, MAX6902_REG_CENTURY, bin2bcd(dt->tm_year / 100)); /* Compulab used a delay here. However, the datasheet * does not mention a delay being required anywhere... */ /* delay(2000); */ /* Write protect */ - max6902_set_reg(dev, 0xF, 0x80); + max6902_set_reg(dev, MAX6902_REG_CONTROL, 0x80); return 0; }