Patchwork powerpc: remove the unneeded trigger of decrementer interrupt in decrementer_check_overflow

login
register
mail settings
Submitter Kevin Hao
Date April 17, 2013, 9:50 a.m.
Message ID <1366192235-17480-1-git-send-email-haokexin@gmail.com>
Download mbox | patch
Permalink /patch/237195/
State Accepted, archived
Commit 3139b0a797d6826519ed98a13623a92f12269613
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Kevin Hao - April 17, 2013, 9:50 a.m.
Previously in order to handle the edge sensitive decrementers,
we choose to set the decrementer to 1 to trigger a decrementer
interrupt when re-enabling interrupts. But with the rework of the
lazy EE, we would replay the decrementer interrupt when re-enabling
interrupts if a decrementer interrupt occurs with irq soft-disabled.
So there is no need to trigger a decrementer interrupt in this case
any more.

Signed-off-by: Kevin Hao <haokexin@gmail.com>
---
 arch/powerpc/kernel/irq.c | 2 --
 1 file changed, 2 deletions(-)

Patch

diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
index 4f97fe3..1af5744 100644
--- a/arch/powerpc/kernel/irq.c
+++ b/arch/powerpc/kernel/irq.c
@@ -116,8 +116,6 @@  static inline notrace int decrementer_check_overflow(void)
  	u64 now = get_tb_or_rtc();
  	u64 *next_tb = &__get_cpu_var(decrementers_next_tb);
  
-	if (now >= *next_tb)
-		set_dec(1);
 	return now >= *next_tb;
 }