| Message ID | 1366186333-5378-1-git-send-email-bjorn@mork.no |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi, On Wed, Apr 17, 2013 at 4:12 PM, Bjørn Mork <bjorn@mork.no> wrote: > Remove warning introduced by commit 418fc57 ("usbnet: cdc-ether: apply > usbnet_link_change"): > > CHECK .../drivers/net/usb/cdc_ether.c > .../drivers/net/usb/cdc_ether.c:409:46: warning: incorrect type in argument 2 (different base types) > .../drivers/net/usb/cdc_ether.c:409:46: expected bool [unsigned] [usertype] <noident> > .../drivers/net/usb/cdc_ether.c:409:46: got restricted __le16 [usertype] wValue > > Cc: Ming Lei <ming.lei@canonical.com> > Signed-off-by: Bjørn Mork <bjorn@mork.no> Thanks for the fix. Acked-by: Ming Lei <ming.lei@canonical.com> Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Bjørn Mork <bjorn@mork.no> Date: Wed, 17 Apr 2013 10:12:13 +0200 > Remove warning introduced by commit 418fc57 ("usbnet: cdc-ether: apply > usbnet_link_change"): > > CHECK .../drivers/net/usb/cdc_ether.c > .../drivers/net/usb/cdc_ether.c:409:46: warning: incorrect type in argument 2 (different base types) > .../drivers/net/usb/cdc_ether.c:409:46: expected bool [unsigned] [usertype] <noident> > .../drivers/net/usb/cdc_ether.c:409:46: got restricted __le16 [usertype] wValue > > Cc: Ming Lei <ming.lei@canonical.com> > Signed-off-by: Bjørn Mork <bjorn@mork.no> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index e965806..4ff71d6 100644 --- a/drivers/net/usb/cdc_ether.c +++ b/drivers/net/usb/cdc_ether.c @@ -406,7 +406,7 @@ void usbnet_cdc_status(struct usbnet *dev, struct urb *urb) case USB_CDC_NOTIFY_NETWORK_CONNECTION: netif_dbg(dev, timer, dev->net, "CDC: carrier %s\n", event->wValue ? "on" : "off"); - usbnet_link_change(dev, event->wValue, 0); + usbnet_link_change(dev, !!event->wValue, 0); break; case USB_CDC_NOTIFY_SPEED_CHANGE: /* tx/rx rates */ netif_dbg(dev, timer, dev->net, "CDC: speed change (len %d)\n",
Remove warning introduced by commit 418fc57 ("usbnet: cdc-ether: apply usbnet_link_change"): CHECK .../drivers/net/usb/cdc_ether.c .../drivers/net/usb/cdc_ether.c:409:46: warning: incorrect type in argument 2 (different base types) .../drivers/net/usb/cdc_ether.c:409:46: expected bool [unsigned] [usertype] <noident> .../drivers/net/usb/cdc_ether.c:409:46: got restricted __le16 [usertype] wValue Cc: Ming Lei <ming.lei@canonical.com> Signed-off-by: Bjørn Mork <bjorn@mork.no> --- drivers/net/usb/cdc_ether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)