From patchwork Wed Apr 17 01:09:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 237132 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gh0-f183.google.com (mail-gh0-f183.google.com [209.85.160.183]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 3B3442C012F for ; Wed, 17 Apr 2013 11:09:18 +1000 (EST) Received: by mail-gh0-f183.google.com with SMTP id r1sf73298ghr.20 for ; Tue, 16 Apr 2013 18:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :references:in-reply-to:subject:date:message-id:mime-version :x-mailer:thread-index:x-brightmail-tracker:x-brightmail-tracker :dlp-filter:x-mtr:x-cfilter-loop:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type:content-language; bh=WaKEf9n5j8UdvgkhDyv4iFbQwzIFSygHRNg0QyOYv/I=; b=hmmapI97irrcethzpLiKpeeK+Fl2pj73cGhEdRLlRaHQxYtGIaOu7m91ml/OwqYsip cwOOuU3JwFc/7NDFwVApy0IMT6S58+D1wkIN/7g8otQQdINP5dEilLwSudkqknRfl5Fi Nh00CZJIdNJMofObcVMFmZgP+K6AghOX5yk1CfxoPkyfNFqNiULhYimJ4DhFSkahTcgG A7AtIM+u1oZQRnbmSV3UQofJ0EchaFcpbN17NvGNcNtE/Jq+/p6Jru+GQ1dPmvlZAZiU wuG0TRRYfwGFUH/jQ+Bemqeg3T7gFfoDRct9sEL1p7lVH/KskMfoKq1HYGkUMkDpXoAT bN7A== X-Received: by 10.50.109.228 with SMTP id hv4mr851649igb.2.1366160956515; Tue, 16 Apr 2013 18:09:16 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.158.225 with SMTP id wx1ls2597759igb.21.canary; Tue, 16 Apr 2013 18:09:16 -0700 (PDT) X-Received: by 10.66.175.228 with SMTP id cd4mr386403pac.24.1366160955859; Tue, 16 Apr 2013 18:09:15 -0700 (PDT) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTP id sz9si805395pbc.2.2013.04.16.18.09.15; Tue, 16 Apr 2013 18:09:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MLD008VKKIS3A90@mailout2.samsung.com> for rtc-linux@googlegroups.com; Wed, 17 Apr 2013 10:09:14 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 66.C2.12250.A36FD615; Wed, 17 Apr 2013 10:09:14 +0900 (KST) X-AuditID: cbfee691-b7f5f6d000002fda-e3-516df63ab262 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 22.07.17838.A36FD615; Wed, 17 Apr 2013 10:09:14 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MLD00DK7KJELKK0@mmp2.samsung.com>; Wed, 17 Apr 2013 10:09:14 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <003001ce3b07$d5f29da0$81d7d8e0$%han@samsung.com> In-reply-to: <003001ce3b07$d5f29da0$81d7d8e0$%han@samsung.com> Subject: [rtc-linux] [PATCH RESEND 8/8] rtc: rtc-twl: convert twl4030rtc_driver to dev_pm_ops Date: Wed, 17 Apr 2013 10:09:14 +0900 Message-id: <003701ce3b08$2d47f230$87d7d690$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac47B9XUIMaX4YjsSbW0FEYgtMIOOAAAE2Ew X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t8zY12rb7mBBlfumlksuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGsVlk5Kak1mW WqRvl8CVsfupSMEv3orvl08zNjDu5+5i5OSQEDCR6D++kxnCFpO4cG89WxcjF4eQwDJGiaev /zPBFD1b28sCkZjOKNE8/zk7hPOLUeL8ndWMIFVsAmoSX74cBkpwcIgI6Eu0tWiA1DAL9DJK nOndzQ5SIyRgK3Gz4xDYVE4BO4lvR+6A9QoLBEvMm/SMDcRmEVCVuLuugwXE5gWqn7a/nQ3C FpT4MfkeWJxZQEti/c7jTBC2vMTmNW+ZQfZKCKhLPPqrCxIWETCSWL6ukw2iRERi34t3jCD3 SAjcY5fY8bmRHWKXgMS3yYdYIHplJTYdgIaEpMTBFTdYJjBKzEKyeRaSzbOQbJ6FZMUCRpZV jKKpBckFxUnpRaZ6xYm5xaV56XrJ+bmbGCGROnEH4/0D1ocYk4HWT2SWEk3OB0Z6Xkm8obGZ kYWpiamxkbmlGWnCSuK86i3WgUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoYL8TJaz/ft6M2 JCntyPyof1911Uu2Bkv87yyd+CauljWzUGlbdPHp+Cc2XrKOK9WbPMtONPddrNZi31o8d7HS mb0fvaok7/+dcvzF86NH8yetDb9+K8X10ovV7tOmfDP5oBY5tZbnSb1tjBv/srq9MyUfHdub 1vhif5vat/8ZZ4+8NN5z/VjmPCWW4oxEQy3mouJEAJf0sRDqAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsVy+t9jQV2rb7mBBqcnGVssuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmLH7qUjBL96K75dPMzYw7ufuYuTkkBAwkXi2 tpcFwhaTuHBvPVsXIxeHkMB0Ronm+c/ZIZxfjBLn76xmBKliE1CT+PLlMFCCg0NEQF+irUUD pIZZoJdR4kzvbnaQGiEBW4mbHYeYQGxOATuJb0fugPUKCwRLzJv0jA3EZhFQlbi7rgNsMy9Q /bT97WwQtqDEj8n3wOLMAloS63ceZ4Kw5SU2r3nLDLJXQkBd4tFfXZCwiICRxPJ1nWwQJSIS +168Y5zAKDQLyaRZSCbNQjJpFpKWBYwsqxhFUwuSC4qT0nMN9YoTc4tL89L1kvNzNzGC08Az qR2MKxssDjEKcDAq8fBeKMgNFGJNLCuuzD3EKMHBrCTCq7gKKMSbklhZlVqUH19UmpNafIgx GejRicxSosn5wBSVVxJvaGxiZmRpZGZhZGJuTpqwkjjvgVbrQCGB9MSS1OzU1ILUIpgtTByc Ug2MhjUmx87pNngsrtnEWitesEp567TQpxJNflFWU30cpz4J/5S8ZVO019eZ3muKGibO6fa1 UrpRXHWML/p32kINWTeL0woiV5iLVFY/0BBveadZuVptZ8/5k6v/b9hRs0TZOKB9jfHFhVe2 eDWW2jK+VhOYm7pkh4HssoL8eaXuUl9ma0W09E5TYinOSDTUYi4qTgQA2dBRlkcDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Instead of using legacy suspend/resume methods, using newer dev_pm_ops structure allows better control over power management. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-twl.c | 16 ++++++---------- 1 files changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c index 8bc6c80..8751a52 100644 --- a/drivers/rtc/rtc-twl.c +++ b/drivers/rtc/rtc-twl.c @@ -566,11 +566,10 @@ static void twl_rtc_shutdown(struct platform_device *pdev) mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_TIMER_M); } -#ifdef CONFIG_PM - +#ifdef CONFIG_PM_SLEEP static unsigned char irqstat; -static int twl_rtc_suspend(struct platform_device *pdev, pm_message_t state) +static int twl_rtc_suspend(struct device *dev) { irqstat = rtc_irq_bits; @@ -578,17 +577,15 @@ static int twl_rtc_suspend(struct platform_device *pdev, pm_message_t state) return 0; } -static int twl_rtc_resume(struct platform_device *pdev) +static int twl_rtc_resume(struct device *dev) { set_rtc_irq_bit(irqstat); return 0; } - -#else -#define twl_rtc_suspend NULL -#define twl_rtc_resume NULL #endif +static SIMPLE_DEV_PM_OPS(twl_rtc_pm_ops, twl_rtc_suspend, twl_rtc_resume); + #ifdef CONFIG_OF static const struct of_device_id twl_rtc_of_match[] = { {.compatible = "ti,twl4030-rtc", }, @@ -603,11 +600,10 @@ static struct platform_driver twl4030rtc_driver = { .probe = twl_rtc_probe, .remove = twl_rtc_remove, .shutdown = twl_rtc_shutdown, - .suspend = twl_rtc_suspend, - .resume = twl_rtc_resume, .driver = { .owner = THIS_MODULE, .name = "twl_rtc", + .pm = &twl_rtc_pm_ops, .of_match_table = of_match_ptr(twl_rtc_of_match), }, };