From patchwork Wed Apr 17 01:07:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 237126 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gg0-x239.google.com (mail-gg0-x239.google.com [IPv6:2607:f8b0:4002:c02::239]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 22CCB2C011E for ; Wed, 17 Apr 2013 11:07:21 +1000 (EST) Received: by mail-gg0-f185.google.com with SMTP id n2sf384942ggf.22 for ; Tue, 16 Apr 2013 18:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :references:in-reply-to:subject:date:message-id:mime-version :x-mailer:thread-index:x-brightmail-tracker:x-brightmail-tracker :dlp-filter:x-mtr:x-cfilter-loop:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type:content-language; bh=BC1GGysXR8T5Qax6jy0LPWLtxl3RSdBL02mCbGp2iNk=; b=TNZUXjuNFF1xQPY1KdhFmuVQd5PSGvudvmGWniAzv/URA1xGtwy9l3bas791Nfur8S Ku0Jg+h/qBvAScLMw+7LJVfkk1MR2cEZfN4h+JdnnRQKAPBi4earK66bYNgtbN37+ZWo 4zJRMDHJKpR5tC3rfvK6TKR8Vn1Bq1YDb8eVPP38yaYHGoqOGJP1aZKiwKoN+JUuvdFh KSUqLhU1Z97buvLW6pNMkVJbX01JoMUqhj5PbDMvz6iLVogWz9ge/lIahcCqOFzH4cHt sY9NYEAyB9UihZvkDO7pLbJcutKcsS4oyttcHPFg9IDrJjQ6j+8/dqpSXiO94+2h3CfZ k8dQ== X-Received: by 10.50.128.105 with SMTP id nn9mr79722igb.17.1366160838823; Tue, 16 Apr 2013 18:07:18 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.117.70 with SMTP id kc6ls472259igb.33.gmail; Tue, 16 Apr 2013 18:07:18 -0700 (PDT) X-Received: by 10.66.8.69 with SMTP id p5mr369869paa.46.1366160838468; Tue, 16 Apr 2013 18:07:18 -0700 (PDT) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTP id sz9si805008pbc.2.2013.04.16.18.07.18; Tue, 16 Apr 2013 18:07:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MLD00G9MKFPH4C0@mailout2.samsung.com> for rtc-linux@googlegroups.com; Wed, 17 Apr 2013 10:07:17 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.50]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 89.A1.12250.5C5FD615; Wed, 17 Apr 2013 10:07:17 +0900 (KST) X-AuditID: cbfee691-b7f5f6d000002fda-be-516df5c563a2 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 75.86.17838.5C5FD615; Wed, 17 Apr 2013 10:07:17 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MLD00EJAKG58060@mmp1.samsung.com>; Wed, 17 Apr 2013 10:07:17 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <003001ce3b07$d5f29da0$81d7d8e0$%han@samsung.com> In-reply-to: <003001ce3b07$d5f29da0$81d7d8e0$%han@samsung.com> Subject: [rtc-linux] [PATCH RESEND 2/8] rtc: rtc-bfin: convert bfin_rtc_driver to dev_pm_ops Date: Wed, 17 Apr 2013 10:07:17 +0900 Message-id: <003101ce3b07$e7599260$b60cb720$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac47B9XUIMaX4YjsSbW0FEYgtMIOOAAAAY/A X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsVy+t8zI92jX3MDDRY2yFksuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGsVlk5Kak1mW WqRvl8CVcWihRsE93opjj2czNTAu5u5i5OSQEDCRWLRzLzOELSZx4d56ti5GLg4hgWWMEof+ HWWCKVp7vpcRIrGIUWLChB+sEM4vRok9jS0sIFVsAmoSX74cZu9i5OAQEdCXaGvRAKlhFuhl lDjTu5sdpEZIwFbiZschsKmcAnYS347cYQSxhQUCJI4cf8wK0ssioCrx+kElSJgXqLz91hF2 CFtQ4sfke2CrmAW0JNbvPM4EYctLbF7zlhmkVUJAXeLRX12IC4wkDn+TgKgQkdj34h3Y+RIC t9glTj99xgaSYBEQkPg2+RALRKusxKYD0HCQlDi44gbLBEaJWUgWz0KyeBaSxbOQrFjAyLKK UTS1ILmgOCm9yFSvODG3uDQvXS85P3cTIyRKJ+5gvH/A+hBjMtD6icxSosn5wCjPK4k3NDYz sjA1MTU2Mrc0I01YSZxXvcU6UEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVANjIGtQ2ie7lSK3 iv27O+UlWX86Vh/5Y+kkcJxpdYR6j0318swwtzQZjXtvHWf+ufBSs0pnjrlMXD6Xh1dh4rHY Aob6NyL3XoUcsX/4UttC39+gQa76hGZA9I2sAhGWp1KCYj1GOxmvFs/jrzgXX2z8r/pZscWE dwKJwYt8d+6atH69gO5ZVyWW4oxEQy3mouJEAGM/ZszoAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEKsWRmVeSWpSXmKPExsVy+t9jAd2jX3MDDa59k7RYcvEqu8Wc9WvY LC4vvMRqcXnXHDaL/Z0djA6sHnsmnmTzODHjN4tH35ZVjB7T5/1k8vi8SS6ANaqB0SYjNTEl tUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaLuSQlliTilQKCCx uFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMePQQo2Ce7wVxx7PZmpgXMzdxcjJISFgIrH2 fC8jhC0mceHeerYuRi4OIYFFjBITJvxghXB+MUrsaWxhAaliE1CT+PLlMHsXIweHiIC+RFuL BkgNs0Avo8SZ3t3sIDVCArYSNzsOMYHYnAJ2Et+O3AHbICwQIHHk+GNWkF4WAVWJ1w8qQcK8 QOXtt46wQ9iCEj8m3wNbxSygJbF+53EmCFteYvOat8wgrRIC6hKP/upCXGAkcfibBESFiMS+ F+8YJzAKzUIyaBaSQbOQDJqFpGUBI8sqRtHUguSC4qT0XEO94sTc4tK8dL3k/NxNjOAU8Exq B+PKBotDjAIcjEo8vBcKcgOFWBPLiitzDzFKcDArifAqrgIK8aYkVlalFuXHF5XmpBYfYkwG enMis5Rocj4wPeWVxBsam5gZWRqZWRiZmJuTJqwkznug1TpQSCA9sSQ1OzW1ILUIZgsTB6dU A6Pjyfd5rmGVTblbSl+FXqh+/KWpebrUqshc7gPitjqxTg8c38Rm97VHOVxXTuzyFNK881n7 glBuh+Jc+R8d8f/n2+VsW7Lf7rJ19edz8+oNpSUnHX29oFdoIqNCpGKZWaoFY4dB6+nl3+ZF eiyx8Z3ZY7JietKdgMm+j+TmJ7nVCcgLim5lUmIpzkg01GIuKk4EAG9ixidFAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Instead of using legacy suspend/resume methods, using newer dev_pm_ops structure allows better control over power management. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-bfin.c | 18 ++++++------------ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c index 4ec614b..f35b17a 100644 --- a/drivers/rtc/rtc-bfin.c +++ b/drivers/rtc/rtc-bfin.c @@ -402,11 +402,9 @@ static int bfin_rtc_remove(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM -static int bfin_rtc_suspend(struct platform_device *pdev, pm_message_t state) +#ifdef CONFIG_PM_SLEEP +static int bfin_rtc_suspend(struct device *dev) { - struct device *dev = &pdev->dev; - dev_dbg_stamp(dev); if (device_may_wakeup(dev)) { @@ -418,10 +416,8 @@ static int bfin_rtc_suspend(struct platform_device *pdev, pm_message_t state) return 0; } -static int bfin_rtc_resume(struct platform_device *pdev) +static int bfin_rtc_resume(struct device *dev) { - struct device *dev = &pdev->dev; - dev_dbg_stamp(dev); if (device_may_wakeup(dev)) @@ -440,20 +436,18 @@ static int bfin_rtc_resume(struct platform_device *pdev) return 0; } -#else -# define bfin_rtc_suspend NULL -# define bfin_rtc_resume NULL #endif +static SIMPLE_DEV_PM_OPS(bfin_rtc_pm_ops, bfin_rtc_suspend, bfin_rtc_resume); + static struct platform_driver bfin_rtc_driver = { .driver = { .name = "rtc-bfin", .owner = THIS_MODULE, + .pm = &bfin_rtc_pm_ops, }, .probe = bfin_rtc_probe, .remove = bfin_rtc_remove, - .suspend = bfin_rtc_suspend, - .resume = bfin_rtc_resume, }; module_platform_driver(bfin_rtc_driver);