Patchwork qemu-iotests: send 'rbd rm ...' stderr to /dev/null

login
register
mail settings
Submitter Sage Weil
Date April 16, 2013, 10:01 p.m.
Message ID <1366149674-21452-1-git-send-email-sage@inktank.com>
Download mbox | patch
Permalink /patch/237121/
State New
Headers show

Comments

Sage Weil - April 16, 2013, 10:01 p.m.
The rbd cli tool now sends progress info to stderr; send that to the bit
bucket too.

Signed-off-by: Sage Weil <sage@inktank.com>
---
 tests/qemu-iotests/common.rc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Stefan Hajnoczi - April 17, 2013, 8:40 a.m.
On Tue, Apr 16, 2013 at 03:01:14PM -0700, Sage Weil wrote:
> The rbd cli tool now sends progress info to stderr; send that to the bit
> bucket too.
> 
> Signed-off-by: Sage Weil <sage@inktank.com>
> ---
>  tests/qemu-iotests/common.rc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Can you add a --quiet or --no-progress option to the rbd cli?

The QEMU patch is simple and could be applied, but rbd cli's approach
prevents users from receiving legitimate error messages when they don't
want verbose progress output.  IMO that should be fixed instead.

Stefan

Patch

diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
index a536bf7..d7b0ad1 100644
--- a/tests/qemu-iotests/common.rc
+++ b/tests/qemu-iotests/common.rc
@@ -152,7 +152,7 @@  _cleanup_test_img()
             ;;
 
         rbd)
-            rbd rm $TEST_DIR/t.$IMGFMT > /dev/null
+            rbd rm $TEST_DIR/t.$IMGFMT > /dev/null 2> /dev/null
             ;;
 
         sheepdog)