Patchwork packet: remove some pointless conditionals before kfree_skb()

login
register
mail settings
Submitter Wei Yongjun
Date Feb. 25, 2009, 10:36 a.m.
Message ID <49A51F3A.3010907@cn.fujitsu.com>
Download mbox | patch
Permalink /patch/23702/
State Accepted
Delegated to: David Miller
Headers show

Comments

Wei Yongjun - Feb. 25, 2009, 10:36 a.m.
Remove some pointless conditionals before kfree_skb().

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
 net/packet/af_packet.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
David Miller - Feb. 27, 2009, 7:09 a.m.
From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Wed, 25 Feb 2009 18:36:42 +0800

> Remove some pointless conditionals before kfree_skb().
> 
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 1fc4a78..d8cc006 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -756,8 +756,7 @@  ring_is_full:
 	spin_unlock(&sk->sk_receive_queue.lock);
 
 	sk->sk_data_ready(sk, 0);
-	if (copy_skb)
-		kfree_skb(copy_skb);
+	kfree_skb(copy_skb);
 	goto drop_n_restore;
 }