Patchwork [v2,6/7] hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h

login
register
mail settings
Submitter Laszlo Ersek
Date April 15, 2013, 8:47 p.m.
Message ID <1366058872-11196-7-git-send-email-lersek@redhat.com>
Download mbox | patch
Permalink /patch/236724/
State New
Headers show

Comments

Laszlo Ersek - April 15, 2013, 8:47 p.m.
From: Michael S. Tsirkin <mst@redhat.com>


Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 include/hw/i386/apic.h |    2 ++
 hw/i386/pc.c           |    2 --
 2 files changed, 2 insertions(+), 2 deletions(-)
Eric Blake - April 15, 2013, 9:06 p.m.
On 04/15/2013 02:47 PM, Laszlo Ersek wrote:
> From: Michael S. Tsirkin <mst@redhat.com>
> 
> 
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

If Michael is the original author, don't we need his S-o-b?
Laszlo Ersek - April 15, 2013, 9:27 p.m.
On 04/15/13 23:06, Eric Blake wrote:
> On 04/15/2013 02:47 PM, Laszlo Ersek wrote:
>> From: Michael S. Tsirkin <mst@redhat.com>
>>
>>
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> 
> If Michael is the original author, don't we need his S-o-b?

Yeah, probably. Sorry about that. Should I resend just for this?
Thanks
Laszlo

Patch

diff --git a/include/hw/i386/apic.h b/include/hw/i386/apic.h
index 1d48e02..edbb37f 100644
--- a/include/hw/i386/apic.h
+++ b/include/hw/i386/apic.h
@@ -26,6 +26,8 @@  void apic_designate_bsp(DeviceState *d);
 /* pc.c */
 DeviceState *cpu_get_current_apic(void);
 
+#define IO_APIC_DEFAULT_ADDRESS 0xfec00000
+
 /* cpu.c */
 bool cpu_is_bsp(X86CPU *cpu);
 
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 3c12b55..8727489 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -73,8 +73,6 @@ 
 #define FW_CFG_E820_TABLE (FW_CFG_ARCH_LOCAL + 3)
 #define FW_CFG_HPET (FW_CFG_ARCH_LOCAL + 4)
 
-#define IO_APIC_DEFAULT_ADDRESS 0xfec00000
-
 #define E820_NR_ENTRIES		16
 
 struct e820_entry {