| Message ID | 1366052997-12435-3-git-send-email-vyasevic@redhat.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Vlad Yasevich <vyasevic@redhat.com> Date: Mon, 15 Apr 2013 15:09:57 -0400 > Team drivers attempts to sync addresses to each of of the port ^^^^^ Maybe you meant only one "of" here. > devices; however, the current api doesn't do anything for anything > after the first device. Switch to using the new api that will > actually sync the addresses to all ports. "anything for anything" sounds awkward, perhaps "anything for devices on the list after the first device" or something like that. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/15/2013 03:45 PM, David Miller wrote: > From: Vlad Yasevich <vyasevic@redhat.com> > Date: Mon, 15 Apr 2013 15:09:57 -0400 > >> Team drivers attempts to sync addresses to each of of the port > ^^^^^ > > Maybe you meant only one "of" here. > >> devices; however, the current api doesn't do anything for anything >> after the first device. Switch to using the new api that will >> actually sync the addresses to all ports. > > "anything for anything" sounds awkward, perhaps "anything for devices > on the list after the first device" or something like that. > yes will fix. -vlad > Thanks. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index bf34192..33d89f8 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1491,8 +1491,8 @@ static void team_set_rx_mode(struct net_device *dev) rcu_read_lock(); list_for_each_entry_rcu(port, &team->port_list, list) { - dev_uc_sync(port->dev, dev); - dev_mc_sync(port->dev, dev); + dev_uc_sync_multiple(port->dev, dev); + dev_mc_sync_multiple(port->dev, dev); } rcu_read_unlock(); }
Team drivers attempts to sync addresses to each of of the port devices; however, the current api doesn't do anything for anything after the first device. Switch to using the new api that will actually sync the addresses to all ports. CC: Jiri Pirko <jiri@resnulli.us> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com> --- drivers/net/team/team.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)