Patchwork [Raring,SRU,PULL] quirk PROBE_DEF for OmniVision webcam

login
register
mail settings
Submitter Kamal Mostafa
Date April 15, 2013, 7:27 p.m.
Message ID <1366054058.4159.101.camel@fourier>
Download mbox
Permalink /patch/236704/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/kamal/ubuntu-raring.git lp1168430

Comments

Kamal Mostafa - April 15, 2013, 7:27 p.m.
*This patch has been sent upstream.

Bug reference:

        https://bugs.launchpad.net/bugs/1168430
        monitor webcam not detected (intermitent)

[IMPACT]

This model-specific quirk fixes an observed Raring regression
from 12.10.

Some models of OmniVision webcam need a pre-existing quirk in
order to avoid a condition which prevents the driver from
recognizing the harware consistently.  Some timing difference
between 12.10 and Raring exposed the problem for this particular
OmniVision model, which wasn't in the quirk list.

[TESTCASE]

Bug reporter confirms that adding this model to the quirk list
fixes the problem, allowing the webcam to be consistently recognized
in Raring.

[Regression Potential]

Very low risk: This patch affects only this particular machine
and webcam model, and only inhibits the query for a feature which
this webcam doesn't support anyway.

Thanks,

 -Kamal

-------- >8 ----------------------------------------------------

The following changes since commit c4558a72f5420a930a6f94f91b8b0440a595590f:

  Linux 3.8.7 (2013-04-12 12:51:12 -0600)

are available in the git repository at:

  git://kernel.ubuntu.com/kamal/ubuntu-raring.git lp1168430

for you to fetch changes up to d8f88f121508231833b6cabce4aaccf6a4d8b077:

  UBUNTU: SAUCE: [media] uvcvideo: quirk PROBE_DEF for Dell Studio / OmniVision webcam (2013-04-15 12:04:54 -0700)

----------------------------------------------------------------
Kamal Mostafa (1):
      UBUNTU: SAUCE: [media] uvcvideo: quirk PROBE_DEF for Dell Studio / OmniVision webcam

 drivers/media/usb/uvc/uvc_driver.c |    9 +++++++++
 1 file changed, 9 insertions(+)
Leann Ogasawara - April 15, 2013, 7:48 p.m.
This is a device specific quirk and should have little to no risk of
regression.  It's also received positive test confirmation by the
original bug reporter.

Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com>

On 04/15/2013 12:27 PM, Kamal Mostafa wrote:
> *This patch has been sent upstream.
>
> Bug reference:
>
>         https://bugs.launchpad.net/bugs/1168430
>         monitor webcam not detected (intermitent)
>
> [IMPACT]
>
> This model-specific quirk fixes an observed Raring regression
> from 12.10.
>
> Some models of OmniVision webcam need a pre-existing quirk in
> order to avoid a condition which prevents the driver from
> recognizing the harware consistently.  Some timing difference
> between 12.10 and Raring exposed the problem for this particular
> OmniVision model, which wasn't in the quirk list.
>
> [TESTCASE]
>
> Bug reporter confirms that adding this model to the quirk list
> fixes the problem, allowing the webcam to be consistently recognized
> in Raring.
>
> [Regression Potential]
>
> Very low risk: This patch affects only this particular machine
> and webcam model, and only inhibits the query for a feature which
> this webcam doesn't support anyway.
>
> Thanks,
>
>  -Kamal
>
> -------- >8 ----------------------------------------------------
>
> The following changes since commit c4558a72f5420a930a6f94f91b8b0440a595590f:
>
>   Linux 3.8.7 (2013-04-12 12:51:12 -0600)
>
> are available in the git repository at:
>
>   git://kernel.ubuntu.com/kamal/ubuntu-raring.git lp1168430
>
> for you to fetch changes up to d8f88f121508231833b6cabce4aaccf6a4d8b077:
>
>   UBUNTU: SAUCE: [media] uvcvideo: quirk PROBE_DEF for Dell Studio / OmniVision webcam (2013-04-15 12:04:54 -0700)
>
> ----------------------------------------------------------------
> Kamal Mostafa (1):
>       UBUNTU: SAUCE: [media] uvcvideo: quirk PROBE_DEF for Dell Studio / OmniVision webcam
>
>  drivers/media/usb/uvc/uvc_driver.c |    9 +++++++++
>  1 file changed, 9 insertions(+)
>
>
>
Stefan Bader - April 16, 2013, 12:05 p.m.
On 15.04.2013 21:27, Kamal Mostafa wrote:
> git://kernel.ubuntu.com/kamal/ubuntu-raring.git lp1168430

Looks isolated enough. Only nasty thing might be that this looks like one of
those patches that can be applied an infinite number of times.
Tim Gardner - April 16, 2013, 12:25 p.m.