Patchwork [qom-cpu,2/7] target-i386/kvm.c: Code formatting changes

login
register
mail settings
Submitter Eduardo Habkost
Date April 15, 2013, 7:25 p.m.
Message ID <1366053940-9401-3-git-send-email-ehabkost@redhat.com>
Download mbox | patch
Permalink /patch/236701/
State New
Headers show

Comments

Eduardo Habkost - April 15, 2013, 7:25 p.m.
Add appropriate spaces around operators, and break line where it needs
to be broken to allow feature-words array to be introduced without
having too-long lines.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target-i386/kvm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Igor Mammedov - April 16, 2013, 2:23 p.m.
On Mon, 15 Apr 2013 16:25:35 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

> Add appropriate spaces around operators, and break line where it needs
> to be broken to allow feature-words array to be introduced without
> having too-long lines.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/kvm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 397afeb..375219a 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -610,7 +610,8 @@ int kvm_arch_init_vcpu(CPUState *cs)
>      cpuid_data.cpuid.nent = cpuid_i;
>  
>      if (((env->cpuid_version >> 8)&0xF) >= 6
> -        && (env->cpuid_features&(CPUID_MCE|CPUID_MCA)) ==
> (CPUID_MCE|CPUID_MCA)
> +        && (env->cpuid_features & (CPUID_MCE|CPUID_MCA)) ==
> +            (CPUID_MCE|CPUID_MCA)
small nit,     ^ perhaps better to align it along with statement above
  
>          && kvm_check_extension(cs->kvm_state, KVM_CAP_MCE) > 0) {
>          uint64_t mcg_cap;
>          int banks;

Reviewed-By: Igor Mammedov <imammedo@redhat.com>
Eduardo Habkost - April 16, 2013, 2:35 p.m.
On Tue, Apr 16, 2013 at 04:23:07PM +0200, Igor Mammedov wrote:
> On Mon, 15 Apr 2013 16:25:35 -0300
> Eduardo Habkost <ehabkost@redhat.com> wrote:
> 
> > Add appropriate spaces around operators, and break line where it needs
> > to be broken to allow feature-words array to be introduced without
> > having too-long lines.
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >  target-i386/kvm.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> > index 397afeb..375219a 100644
> > --- a/target-i386/kvm.c
> > +++ b/target-i386/kvm.c
> > @@ -610,7 +610,8 @@ int kvm_arch_init_vcpu(CPUState *cs)
> >      cpuid_data.cpuid.nent = cpuid_i;
> >  
> >      if (((env->cpuid_version >> 8)&0xF) >= 6
> > -        && (env->cpuid_features&(CPUID_MCE|CPUID_MCA)) ==
> > (CPUID_MCE|CPUID_MCA)
> > +        && (env->cpuid_features & (CPUID_MCE|CPUID_MCA)) ==
> > +            (CPUID_MCE|CPUID_MCA)
> small nit,     ^ perhaps better to align it along with statement above

I aligned it to the right of the opening parenthesis as it was inside
it...

...except that I was wrong, and it is _not_ inside the parenthesis in
the line above, so my alignment choice was misleading.

Andreas, do you mind changing the alignment before applying, to avoid
yet another respin?


>   
> >          && kvm_check_extension(cs->kvm_state, KVM_CAP_MCE) > 0) {
> >          uint64_t mcg_cap;
> >          int banks;
> 
> Reviewed-By: Igor Mammedov <imammedo@redhat.com>

Patch

diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 397afeb..375219a 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -610,7 +610,8 @@  int kvm_arch_init_vcpu(CPUState *cs)
     cpuid_data.cpuid.nent = cpuid_i;
 
     if (((env->cpuid_version >> 8)&0xF) >= 6
-        && (env->cpuid_features&(CPUID_MCE|CPUID_MCA)) == (CPUID_MCE|CPUID_MCA)
+        && (env->cpuid_features & (CPUID_MCE|CPUID_MCA)) ==
+            (CPUID_MCE|CPUID_MCA)
         && kvm_check_extension(cs->kvm_state, KVM_CAP_MCE) > 0) {
         uint64_t mcg_cap;
         int banks;