| Message ID | 1366053940-9401-5-git-send-email-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Mon, 15 Apr 2013 16:25:37 -0300 Eduardo Habkost <ehabkost@redhat.com> wrote: > Break lines so they don't get too long once the *_features fields are > replaced by an array. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > target-i386/cpu.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 732cafd..5390ca5 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -918,8 +918,10 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def) > x86_cpu_def->stepping = eax & 0x0F; > > x86_cpu_def->level = kvm_arch_get_supported_cpuid(s, 0x0, 0, R_EAX); > - x86_cpu_def->features = kvm_arch_get_supported_cpuid(s, 0x1, 0, R_EDX); > - x86_cpu_def->ext_features = kvm_arch_get_supported_cpuid(s, 0x1, 0, > R_ECX); > + x86_cpu_def->features = > + kvm_arch_get_supported_cpuid(s, 0x1, 0, R_EDX); > + x86_cpu_def->ext_features = > + kvm_arch_get_supported_cpuid(s, 0x1, 0, R_ECX); > > if (x86_cpu_def->level >= 7) { > x86_cpu_def->cpuid_7_0_ebx_features = Reviewed 4-6/7 patches, they look good, I'd though would merge them since they are doing the same repetitive thing and easy to review.
On Tue, Apr 16, 2013 at 05:18:08PM +0200, Igor Mammedov wrote: > On Mon, 15 Apr 2013 16:25:37 -0300 > Eduardo Habkost <ehabkost@redhat.com> wrote: > > > Break lines so they don't get too long once the *_features fields are > > replaced by an array. > > > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > > --- > > target-i386/cpu.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > index 732cafd..5390ca5 100644 > > --- a/target-i386/cpu.c > > +++ b/target-i386/cpu.c > > @@ -918,8 +918,10 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def) > > x86_cpu_def->stepping = eax & 0x0F; > > > > x86_cpu_def->level = kvm_arch_get_supported_cpuid(s, 0x0, 0, R_EAX); > > - x86_cpu_def->features = kvm_arch_get_supported_cpuid(s, 0x1, 0, R_EDX); > > - x86_cpu_def->ext_features = kvm_arch_get_supported_cpuid(s, 0x1, 0, > > R_ECX); > > + x86_cpu_def->features = > > + kvm_arch_get_supported_cpuid(s, 0x1, 0, R_EDX); > > + x86_cpu_def->ext_features = > > + kvm_arch_get_supported_cpuid(s, 0x1, 0, R_ECX); > > > > if (x86_cpu_def->level >= 7) { > > x86_cpu_def->cpuid_7_0_ebx_features = > > Reviewed 4-6/7 patches, they look good, I'd though would merge them since > they are doing the same repetitive thing and easy to review. Thanks! I sent them as separate patches so they could be discussed and cherry-picked individually if necessary, but I really don't mind merging all of them. My previous version of this series even included everything (patches 1-7) as a single patch. :-) Andreas, how should we proceed?
diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 732cafd..5390ca5 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -918,8 +918,10 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def) x86_cpu_def->stepping = eax & 0x0F; x86_cpu_def->level = kvm_arch_get_supported_cpuid(s, 0x0, 0, R_EAX); - x86_cpu_def->features = kvm_arch_get_supported_cpuid(s, 0x1, 0, R_EDX); - x86_cpu_def->ext_features = kvm_arch_get_supported_cpuid(s, 0x1, 0, R_ECX); + x86_cpu_def->features = + kvm_arch_get_supported_cpuid(s, 0x1, 0, R_EDX); + x86_cpu_def->ext_features = + kvm_arch_get_supported_cpuid(s, 0x1, 0, R_ECX); if (x86_cpu_def->level >= 7) { x86_cpu_def->cpuid_7_0_ebx_features =
Break lines so they don't get too long once the *_features fields are replaced by an array. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- target-i386/cpu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)