Patchwork [fortran] PR 56919 SYSTEM_CLOCK on Windows

login
register
mail settings
Submitter Tobias Burnus
Date April 15, 2013, 12:51 p.m.
Message ID <516BF7D6.3010002@net-b.de>
Download mbox | patch
Permalink /patch/236589/
State New
Headers show

Comments

Tobias Burnus - April 15, 2013, 12:51 p.m.
Janne Blomqvist wrote:
> I committed the attached patch with most of your suggestions as r197968.

Thanks! Although, I assume you meant "kind=8" in the last sentence:

> +the underlying platform clock. @var{COUNT_MAX} usually equals
> +@code{HUGE(COUNT_MAX)}. Note that the millisecond resolution of the
> +@var{kind=4} version implies that the @var{COUNT} will wrap around in
> +roughly 25 days. In order to avoid issues with the wrap around and for
> +more precise timing, please use the @var{kind=4} version.

Hence, I committed the attached patch as obvious.

Tobias
Janne Blomqvist - April 15, 2013, 12:54 p.m.
On Mon, Apr 15, 2013 at 3:51 PM, Tobias Burnus <burnus@net-b.de> wrote:
> Janne Blomqvist wrote:
>>
>> I committed the attached patch with most of your suggestions as r197968.
>
>
> Thanks! Although, I assume you meant "kind=8" in the last sentence:
>
>> +the underlying platform clock. @var{COUNT_MAX} usually equals
>> +@code{HUGE(COUNT_MAX)}. Note that the millisecond resolution of the
>> +@var{kind=4} version implies that the @var{COUNT} will wrap around in
>> +roughly 25 days. In order to avoid issues with the wrap around and for
>> +more precise timing, please use the @var{kind=4} version.
>
>
> Hence, I committed the attached patch as obvious.

Indeed, thanks for spotting it, and fixing it quickly!


--
Janne Blomqvist

Patch

Index: gcc/fortran/ChangeLog
===================================================================
--- gcc/fortran/ChangeLog	(Revision 197969)
+++ gcc/fortran/ChangeLog	(Arbeitskopie)
@@ -1,3 +1,7 @@ 
+2013-04-15  Tobias Burnus  <burnus@net-b.de>
+
+	* intrinsic.texi (SYSTEM_CLOCK): Recommend kind=8.
+
 2013-04-15  Janne Blomqvist  <jb@gcc.gnu.org>
 
 	PR fortran/56919
Index: gcc/fortran/intrinsic.texi
===================================================================
--- gcc/fortran/intrinsic.texi	(Revision 197969)
+++ gcc/fortran/intrinsic.texi	(Arbeitskopie)
@@ -12052,7 +12052,7 @@ 
 @code{HUGE(COUNT_MAX)}. Note that the millisecond resolution of the
 @var{kind=4} version implies that the @var{COUNT} will wrap around in
 roughly 25 days. In order to avoid issues with the wrap around and for
-more precise timing, please use the @var{kind=4} version.
+more precise timing, please use the @var{kind=8} version.
 
 If there is no clock, or querying the clock fails, @var{COUNT} is set
 to @code{-HUGE(COUNT)}, and @var{COUNT_RATE} and @var{COUNT_MAX} are