Patchwork [1/2] xfstests: dump _require_fio output to log

login
register
mail settings
Submitter Dmitri Monakho
Date April 15, 2013, 11:09 a.m.
Message ID <1366024188-21756-1-git-send-email-dmonakhov@openvz.org>
Download mbox | patch
Permalink /patch/236568/
State Not Applicable
Headers show

Comments

Dmitri Monakho - April 15, 2013, 11:09 a.m.
This should helps to find incompatibility issues.

Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
 common/rc      |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
 mode change 100644 => 100755 tests/ext4/301

diff --git a/tests/ext4/301 b/tests/ext4/301
old mode 100644
new mode 100755
Rich Johnston - April 22, 2013, 3:19 p.m.
Yes I agree this will help, looks good.

--Rich

Reviewed-by: Rich Johnston <rjohnston@sgi.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rich Johnston - April 22, 2013, 3:30 p.m.
On 04/15/2013 06:09 AM, Dmitry Monakhov wrote:

> diff --git a/tests/ext4/301 b/tests/ext4/301
> old mode 100644
> new mode 100755
>
Sorry I forgot to mention this change was unrelated to this patch.

tests/ext4/30? are changed to 755 in commit 'ca9fe94e'.

Thanks for this patch Dmitry, it has been committed.

--Rich


commit 6105b952f46cddf88029d14857cb2658cdab2d52
Author: Dmitry Monakhov <dmonakhov@openvz.org>
Date:   Mon Apr 15 11:09:47 2013 +0000

     xfstests: dump _require_fio output to log

     This should help find incompatibility issues.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/common/rc b/common/rc
index 09fb83f..ad3e378 100644
--- a/common/rc
+++ b/common/rc
@@ -1967,8 +1967,8 @@  _require_fio()
 		return 1;
 	fi
 
-	$FIO_PROG --warnings-fatal --showcmd $job >/dev/null 2>&1
-	[ $? -eq 0 ] || _notrun "$FIO_PROG too old"
+	$FIO_PROG --warnings-fatal --showcmd $job >> $seqres.full 2>&1
+	[ $? -eq 0 ] || _notrun "$FIO_PROG too old, see $seqres.full"
 }
 
 # Does freeze work on this fs?