Message ID | 87k3o4xih1.fsf@openvz.org |
---|---|
State | Not Applicable, archived |
Headers | show |
On Mon, Apr 15, 2013 at 01:15:38PM +0400, Dmitry Monakhov wrote: > > Unfortunately, I don't have the time to debug this, so at least for > > now I'm going to exclude generic/299 from my automated test runs. > Actually fix is quite simple, after this everything works fine. Thanks for the patch! I take it fio isn't gcc -Wall clean? Since otherwise this should have been caught much earlier.... :-( - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 15 Apr 2013 14:43:18 -0400, "Theodore Ts'o" <tytso@mit.edu> wrote: > On Mon, Apr 15, 2013 at 01:15:38PM +0400, Dmitry Monakhov wrote: > > > Unfortunately, I don't have the time to debug this, so at least for > > > now I'm going to exclude generic/299 from my automated test runs. > > Actually fix is quite simple, after this everything works fine. > > Thanks for the patch! I take it fio isn't gcc -Wall clean? Yes it was, log_xxx() methods was declared w/o _format_ attribute. Nor than less Jens already fixed that here: 4e0a8fa259. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From 473842b2c1181245d3bfd1c5cfc6dbad1b695f79 Mon Sep 17 00:00:00 2001 From: root <root@sandy.qa.sw.ru> Date: Mon, 15 Apr 2013 13:12:44 +0400 Subject: [PATCH] fio: fix segfault on 32bits platforms --- stat.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/stat.c b/stat.c index 2665952..f3bc63d 100644 --- a/stat.c +++ b/stat.c @@ -601,7 +601,7 @@ void show_thread_status(struct thread_stat *ts, struct group_run_stats *rs) ts->short_io_u[0], ts->short_io_u[1], ts->short_io_u[2]); if (ts->continue_on_error) { - log_info(" errors : total=%lu, first_error=%d/<%s>\n", + log_info(" errors : total=%llu, first_error=%d/<%s>\n", ts->total_err_count, ts->first_error, strerror(ts->first_error)); -- 1.7.1