Patchwork w64: Fix compiler warnings (wrong format specifier)

login
register
mail settings
Submitter Stefan Weil
Date April 13, 2013, 8:45 p.m.
Message ID <1365885950-27598-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/236391/
State Accepted
Headers show

Comments

Stefan Weil - April 13, 2013, 8:45 p.m.
GetLastError() returns a DWORD value which is unsigned long,
so the correct format specifier is %lu.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---

Debian's w32 cross compiler does not complain about the wrong
specifiers, but the w64 cross compiler does.

I'm sorry that I did not notice this before sending the pull
request.


 cpus.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Stefan Hajnoczi - April 19, 2013, 9:38 a.m.
On Sat, Apr 13, 2013 at 10:45:50PM +0200, Stefan Weil wrote:
> GetLastError() returns a DWORD value which is unsigned long,
> so the correct format specifier is %lu.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> Debian's w32 cross compiler does not complain about the wrong
> specifiers, but the w64 cross compiler does.
> 
> I'm sorry that I did not notice this before sending the pull
> request.
> 
> 
>  cpus.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/cpus.c b/cpus.c
index 97e9ab4..3f754c6 100644
--- a/cpus.c
+++ b/cpus.c
@@ -865,7 +865,7 @@  static void qemu_cpu_kick_thread(CPUState *cpu)
         CONTEXT tcgContext;
 
         if (SuspendThread(cpu->hThread) == (DWORD)-1) {
-            fprintf(stderr, "qemu:%s: GetLastError:%d\n", __func__,
+            fprintf(stderr, "qemu:%s: GetLastError:%lu\n", __func__,
                     GetLastError());
             exit(1);
         }
@@ -881,7 +881,7 @@  static void qemu_cpu_kick_thread(CPUState *cpu)
         cpu_signal(0);
 
         if (ResumeThread(cpu->hThread) == (DWORD)-1) {
-            fprintf(stderr, "qemu:%s: GetLastError:%d\n", __func__,
+            fprintf(stderr, "qemu:%s: GetLastError:%lu\n", __func__,
                     GetLastError());
             exit(1);
         }