Patchwork [MIPS] Fix Many warnings in MIPS port (Was: [PATCH] [MIPS] microMIPS gcc support)

login
register
mail settings
Submitter ddaney.cavm@gmail.com
Date April 12, 2013, 11:28 p.m.
Message ID <516898BB.5050903@gmail.com>
Download mbox | patch
Permalink /patch/236280/
State New
Headers show

Comments

ddaney.cavm@gmail.com - April 12, 2013, 11:28 p.m.
On 04/12/2013 03:07 PM, Moore, Catherine wrote:
> Hi David,
> Please try the attached patch.  Is this OK to checkin?

I don't think it is correct...


> Thanks,
> Catherine
>
> 2013-04-12  Catherine Moore<clm@codesourcery.com>
>
>          * configure.ac (.micromips support): Add --fatal-warnings option.
>          * configure: Regenerate.
>
>
[...]
>
> Index: configure.ac
> ===================================================================
> --- configure.ac	(revision 197936)
> +++ configure.ac	(working copy)
> @@ -4051,6 +4051,12 @@ LCF0:
>         [AC_DEFINE(HAVE_AS_NO_SHARED, 1,
>   		 [Define if the assembler understands -mno-shared.])])
>
> +    gcc_GAS_CHECK_FEATURE([.micromips support],
> +      gcc_cv_as_micromips_support,,[--fatal-warnings],
> +      [.set micromips],,
> +      [AC_DEFINE(HAVE_GAS_MICROMIPS, 1,
> +          [Define if your assembler supports the .set micromips directive])])
> +

There is already an existing check.  Just modify that one instead of 
adding a duplicate.  Something like the attached (untested)

>       gcc_GAS_CHECK_FEATURE([.gnu_attribute support],
>         gcc_cv_as_mips_gnu_attribute, [2,18,0],,
>         [.gnu_attribute 4,1],,


I didn't have time to test this yet.  I may try Monday.

David Daney

Patch

Index: gcc/configure.ac
===================================================================
--- gcc/configure.ac	(revision 197836)
+++ gcc/configure.ac	(working copy)
@@ -4058,7 +4058,7 @@ 
 	  [Define if your assembler supports .gnu_attribute.])])
 
     gcc_GAS_CHECK_FEATURE([.micromips support],
-      gcc_cv_as_micromips_support,,,
+      gcc_cv_as_micromips_support,,[--fatal-warnings],
       [.set micromips],,
       [AC_DEFINE(HAVE_GAS_MICROMIPS, 1,
           [Define if your assembler supports the .set micromips directive])])