From patchwork Fri Apr 12 11:04:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Gautam X-Patchwork-Id: 236036 X-Patchwork-Delegate: marek.vasut@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 242AA2C00B6 for ; Fri, 12 Apr 2013 21:07:32 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 694624A030; Fri, 12 Apr 2013 13:07:30 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mLLt6I0j9GyW; Fri, 12 Apr 2013 13:07:30 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B16694A04A; Fri, 12 Apr 2013 13:07:26 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 342834A03B for ; Fri, 12 Apr 2013 13:07:23 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o94SO6zVudt3 for ; Fri, 12 Apr 2013 13:07:21 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by theia.denx.de (Postfix) with ESMTP id 365CD4A04F for ; Fri, 12 Apr 2013 13:06:56 +0200 (CEST) Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0ML500J0I2VHHWY0@mailout2.samsung.com> for u-boot@lists.denx.de; Fri, 12 Apr 2013 20:06:54 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.126]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 06.6B.07735.ECAE7615; Fri, 12 Apr 2013 20:06:54 +0900 (KST) X-AuditID: cbfee68e-b7f946d000001e37-66-5167eace34ad Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id EA.44.17838.ECAE7615; Fri, 12 Apr 2013 20:06:54 +0900 (KST) Received: from vivekkumarg-linuxpc.sisodomain.com ([107.108.214.169]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0ML500IF52UIWD90@mmp2.samsung.com>; Fri, 12 Apr 2013 20:06:54 +0900 (KST) From: Vivek Gautam To: u-boot@lists.denx.de Date: Fri, 12 Apr 2013 16:34:37 +0530 Message-id: <1365764680-10917-6-git-send-email-gautam.vivek@samsung.com> X-Mailer: git-send-email 1.7.6.5 In-reply-to: <1365764680-10917-1-git-send-email-gautam.vivek@samsung.com> References: <1365764680-10917-1-git-send-email-gautam.vivek@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42JZI2JSp3vuVXqgwbs2VYsvCzrZLdquHGS3 eNPWyGgx5fAXFouWtQdYLb5t2cZosfz1RnaLt3uBSm4+285k8e/SNVYHLo/ZDRdZPObNOsHi sWBTqceda3vYPM7e2cHo0bdlFaPH0x97mQPYo7hsUlJzMstSi/TtErgyvk7jLHjAXtE16Qtj A+N8ti5GTg4JAROJTSeesELYYhIX7q0HinNxCAksZZR4efwnC0zRr2Pz2SES0xklJiz5DdYt JDCFSWLbdx0Qm01AV6Lp7S5GEFtEQELiV/9VMJtZ4CKjxJ1D7iC2sICFxNRlH9hBbBYBVYnl C26CbeYV8JBY9KQfapmCxJvbz5hBbE4BT4nzS9+yQ+zykFjZv5sF5AgJgX3sEnf/vWeFGCQg 8W3yIaAEB1BCVmLTAWaIOZISB1fcYJnAKLyAkWEVo2hqQXJBcVJ6kZFecWJucWleul5yfu4m RmBcnP73rG8H480D1ocYk4HGTWSWEk3OB8ZVXkm8obGZkYWpiamxkbmlGWnCSuK8ai3WgUIC 6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoY3Tcte6fqfn2l2EZbY9u0ktKpl7uKnHO519y2bDyz ZKHfFaN+7XvbPuxd3FYqceH6m7WmJjN5y+tktQ4dt7vdXLSEI8R+2i/T164xkhcinS9s4jbc fTmSta98660Gj4zka39VSpuF7yvP899u38B2uGfifb+SvIu3I+I2yV8rOPPEw+9vwuIfSizF GYmGWsxFxYkA2FGlK6ECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsVy+t9jQd1zr9IDDY59l7H4sqCT3aLtykF2 izdtjYwWUw5/YbFoWXuA1eLblm2MFstfb2S3eLsXqOTms+1MFv8uXWN14PKY3XCRxWPerBMs Hgs2lXrcubaHzePsnR2MHn1bVjF6PP2xlzmAPaqB0SYjNTEltUghNS85PyUzL91WyTs43jne 1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6EAlhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4h QXA9RgZoIGENY8bXaZwFD9gruiZ9YWxgnM/WxcjJISFgIvHr2Hx2CFtM4sK99UBxLg4hgemM EhOW/AYrEhKYwiSx7bsOiM0moCvR9HYXI4gtIiAh8av/KpjNLHCRUeLOIXcQW1jAQmLqsg9g Q1kEVCWWL7jJCmLzCnhILHrSzwKxTEHize1nzCA2p4CnxPmlb9khdnlIrOzfzTKBkXcBI8Mq RtHUguSC4qT0XEO94sTc4tK8dL3k/NxNjOCoeya1g3Flg8UhRgEORiUe3hfC6YFCrIllxZW5 hxglOJiVRHhj9qYFCvGmJFZWpRblxxeV5qQWH2JMBrpqIrOUaHI+MCHklcQbGpuYmxqbWppY mJhZkiasJM57oNU6UEggPbEkNTs1tSC1CGYLEwenVAPj1p4SfY1Vx8VveN11jTqmHWfnFl9i mz11rXp5yY4zmtLlWTW+K1wUWDTOLfVd/2ZyQPzB/rls9Wk5jYemTZ4tFHqOf9mliTtWMc2e ttKlTjCqR9GtSeruoxyjNfuLA9+Wnu68VVEt6vrWvedmM1NQ0PK4OafiHl7/sGP+U5HgY4Ub DjVe3J+ixFKckWioxVxUnAgAHUFLmv4CAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: marex@denx.de, u-boot-review@google.com, patches@linaro.org, gautam.vivek@samsung.com, rajeshwari.s@samsung.com, vikas.sajjan@samsung.com Subject: [U-Boot] [PATCH v3 5/8] usb: hub: Fix enumration timeout X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Patch b6d7852c increases timeout for enumeration, taking worst case to be 10 sec. get_timer() api returns timestamp in milliseconds, which is what we are checking in the do-while() loop in usb_hub_configure() (get_timer(start) < CONFIG_SYS_HZ * 10). This should give us a required check for 10 seconds, and thereby we don't need to add additional mdelay of 100 microseconds in each cycle. Signed-off-by: Vivek Gautam Reviewed-by: Vipin Kumar --- Changes from v2: - none common/usb_hub.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/common/usb_hub.c b/common/usb_hub.c index e4f4e3c..ab41943 100644 --- a/common/usb_hub.c +++ b/common/usb_hub.c @@ -443,7 +443,6 @@ static int usb_hub_configure(struct usb_device *dev) (portstatus & USB_PORT_STAT_CONNECTION)) break; - mdelay(100); } while (get_timer(start) < CONFIG_SYS_HZ * 10); if (ret < 0)