Patchwork [U-Boot] powpc/mpc85xx: explicit cast the SDRAM size to type phys_size_t

login
register
mail settings
Submitter Hu Mingkai-B21284
Date April 12, 2013, 8:34 a.m.
Message ID <CF6CBFBA8EBBB949B6E321556F6E150925346C@039-SN2MPN1-011.039d.mgd.msft.net>
Download mbox | patch
Permalink /patch/236006/
State Not Applicable, archived
Delegated to: Andy Fleming
Headers show

Comments

Hu Mingkai-B21284 - April 12, 2013, 8:34 a.m.
Please ignore this patch because there's a typo in title "powpc".
Thanks,
Mingkai

-----Original Message-----
From: Hu Mingkai-B21284 
Sent: Friday, April 12, 2013 3:53 PM
To: u-boot@lists.denx.de
Cc: Fleming Andy-AFLEMING; sun york-R58495; Hu Mingkai-B21284
Subject: [PATCH] powpc/mpc85xx: explicit cast the SDRAM size to type phys_size_t

To avoid sign extension problem, use explicit casting to cast the SDRAM size to type phys_size_t, or else, if the SDRAM size is 2G(0x80000000), it will be extended to 0xffffffff80000000 when phys_size_t is type 'unsigned long long'.

Signed-off-by: Mingkai Hu <Mingkai.Hu@freescale.com>
---
Based on master branch of git://git.denx.de/u-boot.git Also can apply direcly to git://www.denx.de/git/u-boot-mpc85xx.git

 arch/powerpc/cpu/mpc85xx/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/arch/powerpc/cpu/mpc85xx/cpu.c b/arch/powerpc/cpu/mpc85xx/cpu.c index df2ab6d..ee6fac3 100644
--- a/arch/powerpc/cpu/mpc85xx/cpu.c
+++ b/arch/powerpc/cpu/mpc85xx/cpu.c
@@ -339,7 +339,7 @@  phys_size_t initdram(int board_type)  #if defined(CONFIG_SPD_EEPROM) || defined(CONFIG_DDR_SPD)
 	return fsl_ddr_sdram_size();
 #else
-	return CONFIG_SYS_SDRAM_SIZE * 1024 * 1024;
+	return (phys_size_t)CONFIG_SYS_SDRAM_SIZE * 1024 * 1024;
 #endif
 }
 #else /* CONFIG_SYS_RAMBOOT */
--
1.8.0