From patchwork Thu Apr 11 08:34:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 235699 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 243522C0099 for ; Thu, 11 Apr 2013 21:16:07 +1000 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UQF3r-0002WY-Ff; Thu, 11 Apr 2013 10:48:59 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UQCyX-0001Bq-BH; Thu, 11 Apr 2013 08:35:21 +0000 Received: from mail-pa0-f42.google.com ([209.85.220.42]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UQCyS-0001B5-26 for linux-mtd@lists.infradead.org; Thu, 11 Apr 2013 08:35:16 +0000 Received: by mail-pa0-f42.google.com with SMTP id kq13so787027pab.15 for ; Thu, 11 Apr 2013 01:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=bKtLl1Xiu9AiwC6ssyVEGIhhAPqFHOr8rKXCbn/JfR0=; b=ioRpch2yKDzC8xSzYhNgGBNwOZuLySjcUQMtk5oqX2zv8JCtj9zl/y5MIOI9Mj4U8e rhr1ntPS0chINdboRY0kt+EKBdwryAtUWowV8D/QpQ+jURZbqpxnsw1sMb/JW/6pK+3R HCHVJ4DsqOiiKTHf+d+GEq5phqErlsFEIWti4hMlDUdFnCFANc3PvI6Q7r2N5uGe4tnY Vs1Gvtyiw6OwmfO1Y8IE5yyiP2+CboU9FRiKVSRFwTpvly9R1o4iyPjjI07ksJMAW/o1 qsjkGJNiT+Kb2Z8Eiz0B2+E4Gvm/hoks1zUw+HQfumcxC+6yx8MqmiRotCml4SIYKVaw qEkg== X-Received: by 10.68.134.136 with SMTP id pk8mr7715216pbb.100.1365669314383; Thu, 11 Apr 2013 01:35:14 -0700 (PDT) Received: from ld-irv-0074.broadcom.com (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by mx.google.com with ESMTPS id qr7sm3378366pbc.16.2013.04.11.01.35.13 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 11 Apr 2013 01:35:13 -0700 (PDT) From: Brian Norris To: Subject: [PATCH v2 3/3] mtd: nand: reword nand_chip bad block interface comments Date: Thu, 11 Apr 2013 01:34:59 -0700 Message-Id: <1365669299-6830-3-git-send-email-computersforpeace@gmail.com> X-Mailer: git-send-email 1.8.2 In-Reply-To: <1365669299-6830-1-git-send-email-computersforpeace@gmail.com> References: <1365669299-6830-1-git-send-email-computersforpeace@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130411_043516_211137_3075BB55 X-CRM114-Status: GOOD ( 13.03 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.42 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (computersforpeace[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Brian Norris , Artem Bityutskiy X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This remedies a few problems: (1) The use of "the" vs. "a" is a little confusing, IMO. (2) nand_chip.block_bad is used exclusively for checking the OOB bad block markers of a NAND. Any BBT functionality is handled in nand_bbt.c, so this description should differentiate itself from nand_bbt.c. Signed-off-by: Brian Norris --- v2: no change include/linux/mtd/nand.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h index 6184cc0..2126837 100644 --- a/include/linux/mtd/nand.h +++ b/include/linux/mtd/nand.h @@ -392,8 +392,8 @@ struct nand_buffers { * @write_buf: [REPLACEABLE] write data from the buffer to the chip * @read_buf: [REPLACEABLE] read data from the chip into the buffer * @select_chip: [REPLACEABLE] select chip nr - * @block_bad: [REPLACEABLE] check, if the block is bad - * @block_markbad: [REPLACEABLE] mark the block bad + * @block_bad: [REPLACEABLE] check if a block is bad, using OOB markers + * @block_markbad: [REPLACEABLE] mark a block bad * @cmd_ctrl: [BOARDSPECIFIC] hardwarespecific function for controlling * ALE/CLE/nCE. Also used to write command and address * @init_size: [BOARDSPECIFIC] hardwarespecific function for setting