From patchwork Mon Feb 23 16:47:30 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Meyering X-Patchwork-Id: 23569 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id BD65ADDF0F for ; Tue, 24 Feb 2009 03:47:47 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755389AbZBWQrl (ORCPT ); Mon, 23 Feb 2009 11:47:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755352AbZBWQrl (ORCPT ); Mon, 23 Feb 2009 11:47:41 -0500 Received: from smtp1-g21.free.fr ([212.27.42.1]:36392 "EHLO smtp1-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755325AbZBWQrk (ORCPT ); Mon, 23 Feb 2009 11:47:40 -0500 Received: from smtp1-g21.free.fr (localhost [127.0.0.1]) by smtp1-g21.free.fr (Postfix) with ESMTP id 3426B94013C for ; Mon, 23 Feb 2009 17:47:33 +0100 (CET) Received: from mx.meyering.net (mx.meyering.net [82.230.74.64]) by smtp1-g21.free.fr (Postfix) with ESMTP id 2E9BD940126 for ; Mon, 23 Feb 2009 17:47:31 +0100 (CET) Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 09C0A38A12; Mon, 23 Feb 2009 17:47:30 +0100 (CET) From: Jim Meyering To: linux-ext4@vger.kernel.org Subject: [PATCH] * lib/ext2fs/dosio.c (dos_open): don't leak strdup'd dev name upon error Date: Mon, 23 Feb 2009 17:47:30 +0100 Message-ID: <874oyldrrx.fsf@meyering.net> Lines: 39 MIME-Version: 1.0 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Signed-off-by: Jim Meyering --- Spotted by inspection. For all I know, this is dead code ;-) lib/ext2fs/dosio.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) -- 1.6.2.rc1.266.g4bdf -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/lib/ext2fs/dosio.c b/lib/ext2fs/dosio.c index 97ceef5..a7968cd 100644 --- a/lib/ext2fs/dosio.c +++ b/lib/ext2fs/dosio.c @@ -278,6 +278,7 @@ static errcode_t dos_open(const char *dev, int flags, io_channel *channel) if(!HW_OK()) { _dio_error = ERR_HARDWARE; + free(part->dev); free(part); return EFAULT; } @@ -297,6 +298,7 @@ static errcode_t dos_open(const char *dev, int flags, io_channel *channel) if(!HW_OK()) { _dio_error = ERR_HARDWARE; + free(part->dev); free(part); return EFAULT; } @@ -308,6 +310,7 @@ static errcode_t dos_open(const char *dev, int flags, io_channel *channel) { _dio_error = part->pno == 0xFE ? ERR_EMPTYPART : part->pno == 0xFD ? ERR_LINUXSWAP : ERR_NOTEXT2FS; + free(part->dev); free(part); return ENODEV; }