Patchwork [U-Boot,v3] OMAP5: USB: hsusbtll_clkctrl has to be in hw_auto for USB to work

login
register
mail settings
Submitter Lubomir Popov
Date April 11, 2013, 10:08 a.m.
Message ID <51668BB3.4090100@mm-sol.com>
Download mbox | patch
Permalink /patch/235684/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Lubomir Popov - April 11, 2013, 10:08 a.m.
USB TLL clocks do not support 'explicit_en', only 'hw_auto'
control (R. Sricharan). cm_l3init_hsusbtll_clkctrl has to be
moved to the clk_modules_hw_auto_essential[] array in order
to make the clock work.

This fix is needed (but not sufficient) for USB EHCI operation
in U-Boot.

Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
---
V3 updates commit comments only.
V2 fixes line wrap issue of the patch itself.

 arch/arm/cpu/armv7/omap5/hw_data.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Tom Rini - April 29, 2013, 8:21 p.m.
On Thu, Apr 11, 2013 at 12:08:51AM -0000, Lubomir Popov wrote:

> USB TLL clocks do not support 'explicit_en', only 'hw_auto'
> control (R. Sricharan). cm_l3init_hsusbtll_clkctrl has to be
> moved to the clk_modules_hw_auto_essential[] array in order
> to make the clock work.
> 
> This fix is needed (but not sufficient) for USB EHCI operation
> in U-Boot.
> 
> Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>

Applied to u-boot-ti/master, thanks!

Patch

diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c b/arch/arm/cpu/armv7/omap5/hw_data.c
index ced274e..e5e41fd 100644
--- a/arch/arm/cpu/armv7/omap5/hw_data.c
+++ b/arch/arm/cpu/armv7/omap5/hw_data.c
@@ -403,6 +403,7 @@  void enable_basic_uboot_clocks(void)
 	};
 
 	u32 const clk_modules_hw_auto_essential[] = {
+		(*prcm)->cm_l3init_hsusbtll_clkctrl,
 		0
 	};
 
@@ -411,7 +412,6 @@  void enable_basic_uboot_clocks(void)
 		(*prcm)->cm_l4per_i2c2_clkctrl,
 		(*prcm)->cm_l4per_i2c3_clkctrl,
 		(*prcm)->cm_l4per_i2c4_clkctrl,
-		(*prcm)->cm_l3init_hsusbtll_clkctrl,
 		(*prcm)->cm_l3init_hsusbhost_clkctrl,
 		(*prcm)->cm_l3init_fsusb_clkctrl,
 		0