Patchwork [3.5.y.z,extended,stable] Patch "ALSA: hda - bug fix on return value when getting HDMI ELD" has been added to staging queue

mail settings
Submitter Luis Henriques
Date April 11, 2013, 9:09 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/235618/
State New
Headers show


Luis Henriques - April 11, 2013, 9:09 a.m.
This is a note to let you know that I have just added a patch titled

    ALSA: hda - bug fix on return value when getting HDMI ELD

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see



From 6085f809446c8a469ec915099ad14f74e1aa7c62 Mon Sep 17 00:00:00 2001
From: Mengdong Lin <>
Date: Thu, 28 Mar 2013 05:20:22 -0400
Subject: [PATCH] ALSA: hda - bug fix on return value when getting HDMI ELD

commit 2ef5692efad330b67a234e2c49edad38538751e7 upstream.

In function snd_hdmi_get_eld(), the variable 'ret' should be initialized to 0.
Otherwise it will be returned uninitialized as non-zero after ELD info is got
successfully. Thus hdmi_present_sense() will always assume ELD info is invalid
by mistake, and /proc file system cannot show the proper ELD info.

Signed-off-by: Mengdong Lin <>
Acked-by: David Henningsson <>
Signed-off-by: Takashi Iwai <>
Signed-off-by: Luis Henriques <>
 sound/pci/hda/hda_eld.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c
index 4c054f4..86f6468 100644
--- a/sound/pci/hda/hda_eld.c
+++ b/sound/pci/hda/hda_eld.c
@@ -322,7 +322,7 @@  int snd_hdmi_get_eld(struct hdmi_eld *eld,
 		     struct hda_codec *codec, hda_nid_t nid)
 	int i;
-	int ret;
+	int ret = 0;
 	int size;
 	unsigned char *buf;