| Message ID | 1365643954-20798-3-git-send-email-haokexin@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 9837b43c5f3514e5d28f65f1513f4dc6759d2810 |
| Delegated to: | Scott Wood |
| Headers | show |
On Thu, Apr 11, 2013 at 09:32:34AM +0800, Kevin Hao wrote: > With the patch 7230c564 (powerpc: Rework lazy-interrupt handling), > it seems that the coreint works pretty well on the 85xx 64bit kernel. > So use the coreint by default for these boards. Hi Kumar, Since the external proxy works pretty well with the lazy EE without any change to the current kernel, could you please pick this patch up? This has already been acked by Scott. I also think I got a implicit ack from Benjamin. I will try to use the PACA_IRQ_EE_EDGE to make the support for external proxy more better a little later as suggested by Benjamin. Thanks, Kevin > > Signed-off-by: Kevin Hao <haokexin@gmail.com> > --- > arch/powerpc/platforms/85xx/p5020_ds.c | 5 ----- > arch/powerpc/platforms/85xx/p5040_ds.c | 5 ----- > arch/powerpc/platforms/85xx/t4240_qds.c | 5 ----- > 3 files changed, 15 deletions(-) > > diff --git a/arch/powerpc/platforms/85xx/p5020_ds.c b/arch/powerpc/platforms/85xx/p5020_ds.c > index 753a42c..39cfa40 100644 > --- a/arch/powerpc/platforms/85xx/p5020_ds.c > +++ b/arch/powerpc/platforms/85xx/p5020_ds.c > @@ -75,12 +75,7 @@ define_machine(p5020_ds) { > #ifdef CONFIG_PCI > .pcibios_fixup_bus = fsl_pcibios_fixup_bus, > #endif > -/* coreint doesn't play nice with lazy EE, use legacy mpic for now */ > -#ifdef CONFIG_PPC64 > - .get_irq = mpic_get_irq, > -#else > .get_irq = mpic_get_coreint_irq, > -#endif > .restart = fsl_rstcr_restart, > .calibrate_decr = generic_calibrate_decr, > .progress = udbg_progress, > diff --git a/arch/powerpc/platforms/85xx/p5040_ds.c b/arch/powerpc/platforms/85xx/p5040_ds.c > index 1138185..f70e74c 100644 > --- a/arch/powerpc/platforms/85xx/p5040_ds.c > +++ b/arch/powerpc/platforms/85xx/p5040_ds.c > @@ -66,12 +66,7 @@ define_machine(p5040_ds) { > #ifdef CONFIG_PCI > .pcibios_fixup_bus = fsl_pcibios_fixup_bus, > #endif > -/* coreint doesn't play nice with lazy EE, use legacy mpic for now */ > -#ifdef CONFIG_PPC64 > - .get_irq = mpic_get_irq, > -#else > .get_irq = mpic_get_coreint_irq, > -#endif > .restart = fsl_rstcr_restart, > .calibrate_decr = generic_calibrate_decr, > .progress = udbg_progress, > diff --git a/arch/powerpc/platforms/85xx/t4240_qds.c b/arch/powerpc/platforms/85xx/t4240_qds.c > index 5998e9f..91ead6b 100644 > --- a/arch/powerpc/platforms/85xx/t4240_qds.c > +++ b/arch/powerpc/platforms/85xx/t4240_qds.c > @@ -75,12 +75,7 @@ define_machine(t4240_qds) { > #ifdef CONFIG_PCI > .pcibios_fixup_bus = fsl_pcibios_fixup_bus, > #endif > -/* coreint doesn't play nice with lazy EE, use legacy mpic for now */ > -#ifdef CONFIG_PPC64 > - .get_irq = mpic_get_irq, > -#else > .get_irq = mpic_get_coreint_irq, > -#endif > .restart = fsl_rstcr_restart, > .calibrate_decr = generic_calibrate_decr, > .progress = udbg_progress, > -- > 1.8.1.4 > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev
diff --git a/arch/powerpc/platforms/85xx/p5020_ds.c b/arch/powerpc/platforms/85xx/p5020_ds.c index 753a42c..39cfa40 100644 --- a/arch/powerpc/platforms/85xx/p5020_ds.c +++ b/arch/powerpc/platforms/85xx/p5020_ds.c @@ -75,12 +75,7 @@ define_machine(p5020_ds) { #ifdef CONFIG_PCI .pcibios_fixup_bus = fsl_pcibios_fixup_bus, #endif -/* coreint doesn't play nice with lazy EE, use legacy mpic for now */ -#ifdef CONFIG_PPC64 - .get_irq = mpic_get_irq, -#else .get_irq = mpic_get_coreint_irq, -#endif .restart = fsl_rstcr_restart, .calibrate_decr = generic_calibrate_decr, .progress = udbg_progress, diff --git a/arch/powerpc/platforms/85xx/p5040_ds.c b/arch/powerpc/platforms/85xx/p5040_ds.c index 1138185..f70e74c 100644 --- a/arch/powerpc/platforms/85xx/p5040_ds.c +++ b/arch/powerpc/platforms/85xx/p5040_ds.c @@ -66,12 +66,7 @@ define_machine(p5040_ds) { #ifdef CONFIG_PCI .pcibios_fixup_bus = fsl_pcibios_fixup_bus, #endif -/* coreint doesn't play nice with lazy EE, use legacy mpic for now */ -#ifdef CONFIG_PPC64 - .get_irq = mpic_get_irq, -#else .get_irq = mpic_get_coreint_irq, -#endif .restart = fsl_rstcr_restart, .calibrate_decr = generic_calibrate_decr, .progress = udbg_progress, diff --git a/arch/powerpc/platforms/85xx/t4240_qds.c b/arch/powerpc/platforms/85xx/t4240_qds.c index 5998e9f..91ead6b 100644 --- a/arch/powerpc/platforms/85xx/t4240_qds.c +++ b/arch/powerpc/platforms/85xx/t4240_qds.c @@ -75,12 +75,7 @@ define_machine(t4240_qds) { #ifdef CONFIG_PCI .pcibios_fixup_bus = fsl_pcibios_fixup_bus, #endif -/* coreint doesn't play nice with lazy EE, use legacy mpic for now */ -#ifdef CONFIG_PPC64 - .get_irq = mpic_get_irq, -#else .get_irq = mpic_get_coreint_irq, -#endif .restart = fsl_rstcr_restart, .calibrate_decr = generic_calibrate_decr, .progress = udbg_progress,
With the patch 7230c564 (powerpc: Rework lazy-interrupt handling), it seems that the coreint works pretty well on the 85xx 64bit kernel. So use the coreint by default for these boards. Signed-off-by: Kevin Hao <haokexin@gmail.com> --- arch/powerpc/platforms/85xx/p5020_ds.c | 5 ----- arch/powerpc/platforms/85xx/p5040_ds.c | 5 ----- arch/powerpc/platforms/85xx/t4240_qds.c | 5 ----- 3 files changed, 15 deletions(-)