Patchwork [U-Boot,v2,2/7] pxa_lcd: make lcd_enable() a weak pointer

login
register
mail settings
Submitter Mike Dunn
Date April 11, 2013, 12:45 a.m.
Message ID <1365641128-15812-3-git-send-email-mikedunn@newsguy.com>
Download mbox | patch
Permalink /patch/235524/
State Superseded
Delegated to: Marek Vasut
Headers show

Comments

Mike Dunn - April 11, 2013, 12:45 a.m.
Make lcd_init() a weak pointer so that boards can overload it if necessary.  The
palmtreo680 board needs to wiggle some gpios and configure the pwm controller in
order to get the lcd and its backlight working.

Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
---
 drivers/video/pxa_lcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Marek Vasut - April 11, 2013, 7:15 p.m.
Dear Mike Dunn,

> Make lcd_init() a weak pointer so that boards can overload it if necessary.
>  The palmtreo680 board needs to wiggle some gpios and configure the pwm
> controller in order to get the lcd and its backlight working.
> 
> Signed-off-by: Mike Dunn <mikedunn@newsguy.com>

Reviewed-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

Patch

diff --git a/drivers/video/pxa_lcd.c b/drivers/video/pxa_lcd.c
index d5fbe7b..5e4c685 100644
--- a/drivers/video/pxa_lcd.c
+++ b/drivers/video/pxa_lcd.c
@@ -410,7 +410,7 @@  void lcd_initcolregs (void)
 #endif /* LCD_MONOCHROME */
 
 /*----------------------------------------------------------------------*/
-void lcd_enable (void)
+__weak void lcd_enable(void)
 {
 }