[quantal,sru,pull-request] Input: ALPS - Add new touchpad support

Message ID 5165CB48.70505@canonical.com
State New
Headers show


git://kernel.ubuntu.com/jmleddy/ubuntu-quantal/.git quantal-alps-refresh


James M. Leddy April 10, 2013, 8:27 p.m.

Since we now have fully updated ALPS drivers in raring, I thought it was
about time we SRUed this change to quantal so we can fix a number of
issues that we're experiencing with ALPS touchpads. This enables support
for a number of Dell and other laptops on the market, some of which have
been using unofficial dkms packages in order to get working.

Kent Baxley has tested this patch set extensively, on a number of
systems. Systems that reverted to PS/2 generic mouse before are
supported as ALPS mice with these patches.

Please consider this for inclusion and let me know if there are any

BugLink: https://bugs.launchpad.net/bugs/1089413

The following changes since commit b777ab98bc09d19608ed2835d7f9667b3780d7f5:
  Steve Conklin (1):
        UBUNTU: Ubuntu-3.5.0-28.47

are available in the git repository at:

  git://kernel.ubuntu.com/jmleddy/ubuntu-quantal/.git quantal-alps-refresh

Dave Turvene (1):
      Input: ALPS - add "Dolphin V1" touchpad support

Kevin Cernekee (14):
      Input: ALPS - document the alps.h data structures
      Input: ALPS - copy "model" info into alps_data struct
      Input: ALPS - move alps_get_model() down below hw_init code
      Input: ALPS - introduce helper function for repeated commands
      Input: ALPS - rework detection sequence
      Input: ALPS - use function pointers for different protocol handlers
      Input: ALPS - move {addr,nibble}_command settings into
      Input: ALPS - rework detection of Pinnacle AGx touchpads
      Input: ALPS - fix command mode check
      Input: ALPS - move pixel and bitmap info into alps_data struct
      Input: ALPS - make the V3 packet field decoder "pluggable"
      Input: ALPS - add support for "Rushmore" touchpads
      Input: ALPS - enable trackstick on Rushmore touchpads
      Input: ALPS - remove unused argument to alps_enter_command_mode()

 drivers/input/mouse/alps.c |  848
 drivers/input/mouse/alps.h |  146 +++++++-
 2 files changed, 622 insertions(+), 372 deletions(-)


Stefan Bader April 11, 2013, 8:08 a.m. | #1
I have not looked at the patches. The number of changes is relatively high. But
then it is all contained in one driver for which regressions would have been
noticed in testing quite quickly. So if "extensive" also included older models
using ALPS, I would tend to agree with getting it into Q.

Tim Gardner April 11, 2013, 1:54 p.m. | #2
All clean cherry picks except for 2 trivial conflicts which were noted
in the commit logs.