Patchwork [v2] linux-user: improve target_to_host_sock_type conversion

login
register
mail settings
Submitter Petar Jovanovic
Date April 10, 2013, 6:17 p.m.
Message ID <56EA75BA695AE044ACFB41322F6D2BF4018912E2@bamail02.ba.imgtec.org>
Download mbox | patch
Permalink /patch/235445/
State New
Headers show

Comments

Petar Jovanovic - April 10, 2013, 6:17 p.m.
ping

http://patchwork.ozlabs.org/patch/232770/

Patch

diff --git a/linux-user/socket.h b/linux-user/socket.h
index 339cae5..d2b05dc 100644
--- a/linux-user/socket.h
+++ b/linux-user/socket.h
@@ -1,91 +1,104 @@ 

 #if defined(TARGET_MIPS)
-       // MIPS special values for constants
-
-       /*
-        * For setsockopt(2)
-        *
-        * This defines are ABI conformant as far as Linux supports these ...
-        */
-       #define TARGET_SOL_SOCKET      0xffff
-
-       #define TARGET_SO_DEBUG        0x0001  /* Record debugging information.  */
-       #define TARGET_SO_REUSEADDR    0x0004  /* Allow reuse of local addresses.  */
-       #define TARGET_SO_KEEPALIVE    0x0008  /* Keep connections alive and send
-                                         SIGPIPE when they die.  */
-       #define TARGET_SO_DONTROUTE    0x0010  /* Don't do local routing.  */
-       #define TARGET_SO_BROADCAST    0x0020  /* Allow transmission of
-                                         broadcast messages.  */
-       #define TARGET_SO_LINGER       0x0080  /* Block on close of a reliable
-                                         socket to transmit pending data.  */
-       #define TARGET_SO_OOBINLINE 0x0100     /* Receive out-of-band data in-band.  */
-       #if 0
-       To add: #define TARGET_SO_REUSEPORT 0x0200     /* Allow local address and port reuse.  */
-       #endif
-
-       #define TARGET_SO_TYPE         0x1008  /* Compatible name for SO_STYLE.  */
-       #define TARGET_SO_STYLE        SO_TYPE /* Synonym */
-       #define TARGET_SO_ERROR        0x1007  /* get error status and clear */
-       #define TARGET_SO_SNDBUF       0x1001  /* Send buffer size. */
-       #define TARGET_SO_RCVBUF       0x1002  /* Receive buffer. */
-       #define TARGET_SO_SNDLOWAT     0x1003  /* send low-water mark */
-       #define TARGET_SO_RCVLOWAT     0x1004  /* receive low-water mark */
-       #define TARGET_SO_SNDTIMEO     0x1005  /* send timeout */
-       #define TARGET_SO_RCVTIMEO     0x1006  /* receive timeout */
-       #define TARGET_SO_ACCEPTCONN   0x1009
-
-       /* linux-specific, might as well be the same as on i386 */
-       #define TARGET_SO_NO_CHECK     11
-       #define TARGET_SO_PRIORITY     12
-       #define TARGET_SO_BSDCOMPAT    14
+    /* MIPS special values for constants */
+
+    /*
+     * For setsockopt(2)
+     *
+     * This defines are ABI conformant as far as Linux supports these ...
+     */
+    #define TARGET_SOL_SOCKET      0xffff
+
+    #define TARGET_SO_DEBUG        0x0001  /* Record debugging information. */
+    #define TARGET_SO_REUSEADDR    0x0004  /* Allow reuse of local addresses. */
+    #define TARGET_SO_KEEPALIVE    0x0008  /* Keep connections alive and send
+                                              SIGPIPE when they die. */
+    #define TARGET_SO_DONTROUTE    0x0010  /* Don't do local routing. */
+    #define TARGET_SO_BROADCAST    0x0020  /* Allow transmission of
+                                              broadcast messages. */
+    #define TARGET_SO_LINGER       0x0080  /* Block on close of a reliable
+                                            * socket to transmit pending data.
+                                            */
+    #define TARGET_SO_OOBINLINE 0x0100     /* Receive out-of-band data in-band.
+                                            */
+    #if 0
+    /* To add: Allow local address and port reuse. */
+    #define TARGET_SO_REUSEPORT 0x0200
+    #endif
+
+    #define TARGET_SO_TYPE         0x1008  /* Compatible name for SO_STYLE. */
+    #define TARGET_SO_STYLE        SO_TYPE /* Synonym */
+    #define TARGET_SO_ERROR        0x1007  /* get error status and clear */
+    #define TARGET_SO_SNDBUF       0x1001  /* Send buffer size. */
+    #define TARGET_SO_RCVBUF       0x1002  /* Receive buffer. */
+    #define TARGET_SO_SNDLOWAT     0x1003  /* send low-water mark */
+    #define TARGET_SO_RCVLOWAT     0x1004  /* receive low-water mark */
+    #define TARGET_SO_SNDTIMEO     0x1005  /* send timeout */
+    #define TARGET_SO_RCVTIMEO     0x1006  /* receive timeout */
+    #define TARGET_SO_ACCEPTCONN   0x1009

-       #define TARGET_SO_PASSCRED     17
-       #define TARGET_SO_PEERCRED     18
+    /* linux-specific, might as well be the same as on i386 */
+    #define TARGET_SO_NO_CHECK     11
+    #define TARGET_SO_PRIORITY     12
+    #define TARGET_SO_BSDCOMPAT    14

-       /* Security levels - as per NRL IPv6 - don't actually do anything */
-       #define TARGET_SO_SECURITY_AUTHENTICATION              22
-       #define TARGET_SO_SECURITY_ENCRYPTION_TRANSPORT        23
-       #define TARGET_SO_SECURITY_ENCRYPTION_NETWORK          24
+    #define TARGET_SO_PASSCRED     17
+    #define TARGET_SO_PEERCRED     18

-       #define TARGET_SO_BINDTODEVICE         25
+    /* Security levels - as per NRL IPv6 - don't actually do anything */
+    #define TARGET_SO_SECURITY_AUTHENTICATION              22
+    #define TARGET_SO_SECURITY_ENCRYPTION_TRANSPORT        23
+    #define TARGET_SO_SECURITY_ENCRYPTION_NETWORK          24

-       /* Socket filtering */
-       #define TARGET_SO_ATTACH_FILTER        26
-       #define TARGET_SO_DETACH_FILTER        27
+    #define TARGET_SO_BINDTODEVICE         25

-       #define TARGET_SO_PEERNAME             28
-       #define TARGET_SO_TIMESTAMP            29
-       #define SCM_TIMESTAMP          SO_TIMESTAMP
-
-       #define TARGET_SO_PEERSEC              30
-       #define TARGET_SO_SNDBUFFORCE          31
-       #define TARGET_SO_RCVBUFFORCE          33
-
-       /** sock_type - Socket types
-        *
-        * Please notice that for binary compat reasons MIPS has to
-        * override the enum sock_type in include/linux/net.h, so
-        * we define ARCH_HAS_SOCKET_TYPES here.
-        *
-        * @SOCK_DGRAM - datagram (conn.less) socket
-        * @SOCK_STREAM - stream (connection) socket
-        * @SOCK_RAW - raw socket
-        * @SOCK_RDM - reliably-delivered message
-        * @SOCK_SEQPACKET - sequential packet socket
-        * @SOCK_PACKET - linux specific way of getting packets at the dev level.
-        *               For writing rarp and other similar things on the user level.
-        */
-       enum sock_type {
-              TARGET_SOCK_DGRAM       = 1,
-              TARGET_SOCK_STREAM      = 2,
-              TARGET_SOCK_RAW = 3,
-              TARGET_SOCK_RDM = 4,
-              TARGET_SOCK_SEQPACKET   = 5,
-              TARGET_SOCK_DCCP        = 6,
-              TARGET_SOCK_PACKET      = 10,
-       };
-
-       #define TARGET_SOCK_MAX (SOCK_PACKET + 1)
+    /* Socket filtering */
+    #define TARGET_SO_ATTACH_FILTER        26
+    #define TARGET_SO_DETACH_FILTER        27
+
+    #define TARGET_SO_PEERNAME             28
+    #define TARGET_SO_TIMESTAMP            29
+    #define SCM_TIMESTAMP          SO_TIMESTAMP
+
+    #define TARGET_SO_PEERSEC              30
+    #define TARGET_SO_SNDBUFFORCE          31
+    #define TARGET_SO_RCVBUFFORCE          33
+
+    /** sock_type - Socket types
+     *
+     * Please notice that for binary compat reasons MIPS has to
+     * override the enum sock_type in include/linux/net.h, so
+     * we define ARCH_HAS_SOCKET_TYPES here.
+     *
+     * @SOCK_DGRAM - datagram (conn.less) socket
+     * @SOCK_STREAM - stream (connection) socket
+     * @SOCK_RAW - raw socket
+     * @SOCK_RDM - reliably-delivered message
+     * @SOCK_SEQPACKET - sequential packet socket
+     * @SOCK_DCCP - Datagram Congestion Control Protocol socket
+     * @SOCK_PACKET - linux specific way of getting packets at the dev level.
+     *                For writing rarp and other similar things on the user
+     *                level.
+     * @SOCK_CLOEXEC - sets the close-on-exec (FD_CLOEXEC) flag.
+     * @SOCK_NONBLOCK - sets the O_NONBLOCK file status flag.
+     */
+
+    #define ARCH_HAS_SOCKET_TYPES          1
+
+    enum sock_type {
+           TARGET_SOCK_DGRAM       = 1,
+           TARGET_SOCK_STREAM      = 2,
+           TARGET_SOCK_RAW         = 3,
+           TARGET_SOCK_RDM         = 4,
+           TARGET_SOCK_SEQPACKET   = 5,
+           TARGET_SOCK_DCCP        = 6,
+           TARGET_SOCK_PACKET      = 10,
+           TARGET_SOCK_CLOEXEC     = 02000000,
+           TARGET_SOCK_NONBLOCK    = 0200,
+    };
+
+    #define TARGET_SOCK_MAX (TARGET_SOCK_PACKET + 1)
+    #define TARGET_SOCK_TYPE_MASK    0xf  /* Covers up to TARGET_SOCK_MAX-1. */

 #elif defined(TARGET_ALPHA)

@@ -156,8 +169,81 @@ 
     /* Instruct lower device to use last 4-bytes of skb data as FCS */
     #define TARGET_SO_NOFCS     43

+    /** sock_type - Socket types
+     *
+     * Please notice that for binary compat reasons ALPHA has to
+     * override the enum sock_type in include/linux/net.h, so
+     * we define ARCH_HAS_SOCKET_TYPES here.
+     *
+     * @SOCK_DGRAM - datagram (conn.less) socket
+     * @SOCK_STREAM - stream (connection) socket
+     * @SOCK_RAW - raw socket
+     * @SOCK_RDM - reliably-delivered message
+     * @SOCK_SEQPACKET - sequential packet socket
+     * @SOCK_DCCP - Datagram Congestion Control Protocol socket
+     * @SOCK_PACKET - linux specific way of getting packets at the dev level.
+     *                For writing rarp and other similar things on the user
+     *                level.
+     * @SOCK_CLOEXEC - sets the close-on-exec (FD_CLOEXEC) flag.
+     * @SOCK_NONBLOCK - sets the O_NONBLOCK file status flag.
+     */
+
+    #define ARCH_HAS_SOCKET_TYPES          1
+
+    enum sock_type {
+           TARGET_SOCK_STREAM      = 1,
+           TARGET_SOCK_DGRAM       = 2,
+           TARGET_SOCK_RAW         = 3,
+           TARGET_SOCK_RDM         = 4,
+           TARGET_SOCK_SEQPACKET   = 5,
+           TARGET_SOCK_DCCP        = 6,
+           TARGET_SOCK_PACKET      = 10,
+           TARGET_SOCK_CLOEXEC     = 010000000,
+           TARGET_SOCK_NONBLOCK    = 010000000000,
+    };
+
+    #define TARGET_SOCK_MAX (TARGET_SOCK_PACKET + 1)
+    #define TARGET_SOCK_TYPE_MASK    0xf  /* Covers up to TARGET_SOCK_MAX-1. */
 #else

+#if defined(TARGET_SPARC)
+    /** sock_type - Socket types
+     *
+     * Please notice that for binary compat reasons SPARC has to
+     * override the enum sock_type in include/linux/net.h, so
+     * we define ARCH_HAS_SOCKET_TYPES here.
+     *
+     * @SOCK_DGRAM - datagram (conn.less) socket
+     * @SOCK_STREAM - stream (connection) socket
+     * @SOCK_RAW - raw socket
+     * @SOCK_RDM - reliably-delivered message
+     * @SOCK_SEQPACKET - sequential packet socket
+     * @SOCK_DCCP - Datagram Congestion Control Protocol socket
+     * @SOCK_PACKET - linux specific way of getting packets at the dev level.
+     *                For writing rarp and other similar things on the user
+     *                level.
+     * @SOCK_CLOEXEC - sets the close-on-exec (FD_CLOEXEC) flag.
+     * @SOCK_NONBLOCK - sets the O_NONBLOCK file status flag.
+     */
+
+    #define ARCH_HAS_SOCKET_TYPES          1
+
+    enum sock_type {
+           TARGET_SOCK_STREAM      = 1,
+           TARGET_SOCK_DGRAM       = 2,
+           TARGET_SOCK_RAW         = 3,
+           TARGET_SOCK_RDM         = 4,
+           TARGET_SOCK_SEQPACKET   = 5,
+           TARGET_SOCK_DCCP        = 6,
+           TARGET_SOCK_PACKET      = 10,
+           TARGET_SOCK_CLOEXEC     = 020000000,
+           TARGET_SOCK_NONBLOCK    = 040000,
+    };
+
+    #define TARGET_SOCK_MAX (TARGET_SOCK_PACKET + 1)
+    #define TARGET_SOCK_TYPE_MASK    0xf  /* Covers up to TARGET_SOCK_MAX-1. */
+#endif
+
        /* For setsockopt(2) */
        #define TARGET_SOL_SOCKET      1

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index ee82a2d..5b87c9d 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -1859,30 +1859,38 @@  static void unlock_iovec(struct iovec *vec, abi_ulong target_addr,
     free(vec);
 }

-/* do_socket() Must return target values and target errnos. */
-static abi_long do_socket(int domain, int type, int protocol)
+#if defined(ARCH_HAS_SOCKET_TYPES)
+static inline void target_to_host_sock_type(int *type)
 {
-#if defined(TARGET_MIPS)
-    switch(type) {
+    int host_type = 0;
+    int target_type = *type;
+
+    switch (target_type & TARGET_SOCK_TYPE_MASK) {
     case TARGET_SOCK_DGRAM:
-        type = SOCK_DGRAM;
+        host_type = SOCK_DGRAM;
         break;
     case TARGET_SOCK_STREAM:
-        type = SOCK_STREAM;
-        break;
-    case TARGET_SOCK_RAW:
-        type = SOCK_RAW;
+        host_type = SOCK_STREAM;
         break;
-    case TARGET_SOCK_RDM:
-        type = SOCK_RDM;
-        break;
-    case TARGET_SOCK_SEQPACKET:
-        type = SOCK_SEQPACKET;
-        break;
-    case TARGET_SOCK_PACKET:
-        type = SOCK_PACKET;
+    default:
+        host_type = target_type & TARGET_SOCK_TYPE_MASK;
         break;
     }
+    if (target_type & TARGET_SOCK_CLOEXEC) {
+        host_type |= SOCK_CLOEXEC;
+    }
+    if (target_type & TARGET_SOCK_NONBLOCK) {
+        host_type |= SOCK_NONBLOCK;
+    }
+    *type = host_type;
+}
+#endif
+
+/* do_socket() Must return target values and target errnos. */
+static abi_long do_socket(int domain, int type, int protocol)
+{
+#if defined(ARCH_HAS_SOCKET_TYPES)
+    target_to_host_sock_type(&type);
 #endif
     if (domain == PF_NETLINK)
         return -EAFNOSUPPORT; /* do not NETLINK socket connections possible */
@@ -2116,6 +2124,9 @@  static abi_long do_socketpair(int domain, int type, int protocol,
     int tab[2];
     abi_long ret;

+#if defined(ARCH_HAS_SOCKET_TYPES)
+    target_to_host_sock_type(&type);
+#endif
     ret = get_errno(socketpair(domain, type, protocol, tab));
     if (!is_error(ret)) {
         if (put_user_s32(tab[0], target_tab_addr)