Patchwork toolchain: blackfin: Remove Blackfin toolchain 2011R1 release.

login
register
mail settings
Submitter Sonic Zhang
Date April 10, 2013, 7:50 a.m.
Message ID <1365580213-23039-1-git-send-email-sonic.adi@gmail.com>
Download mbox | patch
Permalink /patch/235325/
State Superseded
Headers show

Comments

Sonic Zhang - April 10, 2013, 7:50 a.m.
From: Sonic Zhang <sonic.zhang@analog.com>

Blackfin is supported in buildroot since 2012R1 release.

Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
---
 toolchain/toolchain-external/Config.in   |   19 -------------------
 toolchain/toolchain-external/ext-tool.mk |    8 +-------
 2 files changed, 1 insertions(+), 26 deletions(-)
Sonic Zhang - May 14, 2013, 7:32 a.m.
Hi Thomas,

On Wed, Apr 10, 2013 at 3:50 PM, Sonic Zhang <sonic.adi@gmail.com> wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> Blackfin is supported in buildroot since 2012R1 release.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> ---
>  toolchain/toolchain-external/Config.in   |   19 -------------------
>  toolchain/toolchain-external/ext-tool.mk |    8 +-------
>  2 files changed, 1 insertions(+), 26 deletions(-)
>
> diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in
> index 6cf29aa..3c6766c 100644
> --- a/toolchain/toolchain-external/Config.in
> +++ b/toolchain/toolchain-external/Config.in
> @@ -614,23 +614,6 @@ config BR2_TOOLCHAIN_EXTERNAL_BLACKFI_UCLINUX_2012R1
>           Toolchain for the Blackfin architecture, from
>           http://blackfin.uclinux.org.
>
> -config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2011R1
> -       bool "Blackfin.uclinux.org 2011R1-RC4"
> -       depends on BR2_bfin
> -       depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
> -       select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
> -       select BR2_INSTALL_LIBSTDCPP
> -       select BR2_LARGEFILE
> -       select BR2_INET_IPV6
> -       select BR2_TOOLCHAIN_HAS_NATIVE_RPC
> -       select BR2_USE_WCHAR
> -       select BR2_TOOLCHAIN_HAS_THREADS
> -       select BR2_TOOLCHAIN_HAS_THREADS_DEBUG
> -       select BR2_HOSTARCH_NEEDS_IA32_LIBS
> -       help
> -         Toolchain for the Blackfin architecture, from
> -         http://blackfin.uclinux.org.
> -
>  config BR2_TOOLCHAIN_EXTERNAL_XILINX_MICROBLAZEEL_V2
>         bool "Xilinx Little Endian Microblaze GNU Tools"
>         depends on BR2_microblazeel
> @@ -758,8 +741,6 @@ config BR2_TOOLCHAIN_EXTERNAL_PREFIX
>         default "i686-pc-linux-gnu"      if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201109
>         default "i686-pc-linux-gnu"      if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201203
>         default "i686-pc-linux-gnu"      if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201209
> -       default "bfin-uclinux"           if BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2011R1 && BR2_BINFMT_FLAT
> -       default "bfin-linux-uclibc"      if BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2011R1 && BR2_BINFMT_FDPIC
>         default "bfin-uclinux"           if BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1 && BR2_BINFMT_FLAT
>         default "bfin-linux-uclibc"      if BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1 && BR2_BINFMT_FDPIC
>         default "bfin-uclinux"           if BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 && BR2_BINFMT_FLAT
> diff --git a/toolchain/toolchain-external/ext-tool.mk b/toolchain/toolchain-external/ext-tool.mk
> index 01578d2..b69d9bb 100644
> --- a/toolchain/toolchain-external/ext-tool.mk
> +++ b/toolchain/toolchain-external/ext-tool.mk
> @@ -260,12 +260,6 @@ TOOLCHAIN_EXTERNAL_SOURCE=ia32-2012.03-27-i686-pc-linux-gnu-i386-linux.tar.bz2
>  else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201209),y)
>  TOOLCHAIN_EXTERNAL_SITE=https://sourcery.mentor.com/public/gnu_toolchain/i686-pc-linux-gnu/
>  TOOLCHAIN_EXTERNAL_SOURCE=ia32-2012.09-62-i686-pc-linux-gnu-i386-linux.tar.bz2
> -else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2011R1),y)
> -TOOLCHAIN_EXTERNAL_SITE_1   = http://blackfin.uclinux.org/gf/download/frsrelease/531/9509/
> -TOOLCHAIN_EXTERNAL_SOURCE_1 = blackfin-toolchain-2011R1-RC4.i386.tar.bz2
> -TOOLCHAIN_EXTERNAL_SITE_2   = http://blackfin.uclinux.org/gf/download/frsrelease/531/9517/
> -TOOLCHAIN_EXTERNAL_SOURCE_2 = blackfin-toolchain-uclibc-full-2011R1-RC4.i386.tar.bz2
> -TOOLCHAIN_EXTERNAL_SOURCE   = $(TOOLCHAIN_EXTERNAL_SOURCE_1) $(TOOLCHAIN_EXTERNAL_SOURCE_2)
>  else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1),y)
>  TOOLCHAIN_EXTERNAL_SITE_1   = http://blackfin.uclinux.org/gf/download/frsrelease/559/9858/
>  TOOLCHAIN_EXTERNAL_SOURCE_1 = blackfin-toolchain-2012R1-RC2.i386.tar.bz2
> @@ -311,7 +305,7 @@ endif
>  # contain ./opt/uClinux/{bfin-uclinux,bfin-linux-uclibc} directories,
>  # which themselves contain the toolchain. This is why we strip more
>  # components than usual.
> -ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2011R1)$(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1)$(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2),y)
> +ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1)$(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2),y)
>  $(DL_DIR)/$(TOOLCHAIN_EXTERNAL_SOURCE_1):
>         $(call DOWNLOAD,$(TOOLCHAIN_EXTERNAL_SITE_1)/$(TOOLCHAIN_EXTERNAL_SOURCE_1))
>
> --


Could you Acked-by this patch at least for -next tree?

Regards,

Sonic
Thomas Petazzoni - May 14, 2013, 7:42 a.m.
Dear Sonic Zhang,

On Tue, 14 May 2013 15:32:05 +0800, Sonic Zhang wrote:

> On Wed, Apr 10, 2013 at 3:50 PM, Sonic Zhang <sonic.adi@gmail.com> wrote:
> > From: Sonic Zhang <sonic.zhang@analog.com>
> >
> > Blackfin is supported in buildroot since 2012R1 release.
> >
> > Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> 
> Could you Acked-by this patch at least for -next tree?

Honestly, I don't understand this patch, and the commit log doesn't
explain much about it.

2012R1 is not a Buildroot version.

And Blackfin toolchains were supported in Buildroot before the 2012R1
release of the Blackfin toolchains.

Could you point to specific problems with this toolchain, or give a
more precise commit log?

Thanks!

Thomas
Sonic Zhang - May 14, 2013, 7:57 a.m.
Hi Thomas,

On Tue, May 14, 2013 at 3:42 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Sonic Zhang,
>
> On Tue, 14 May 2013 15:32:05 +0800, Sonic Zhang wrote:
>
>> On Wed, Apr 10, 2013 at 3:50 PM, Sonic Zhang <sonic.adi@gmail.com> wrote:
>> > From: Sonic Zhang <sonic.zhang@analog.com>
>> >
>> > Blackfin is supported in buildroot since 2012R1 release.
>> >
>> > Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
>>
>> Could you Acked-by this patch at least for -next tree?
>
> Honestly, I don't understand this patch, and the commit log doesn't
> explain much about it.
>
> 2012R1 is not a Buildroot version.
>
> And Blackfin toolchains were supported in Buildroot before the 2012R1
> release of the Blackfin toolchains.
>
> Could you point to specific problems with this toolchain, or give a
> more precise commit log?
>

ADI officially supports the buildroot and related GNU toolchain for
Blackfin since ADI's 2012R1 release only. In order to avoid confusion,
it is better to remove the 2011R1 GNU toolchain for Blackfin. In
addition, the 2011R1 GNU toolchain for Blackfin doesn't support the
BF60x processors.

Regards,

Sonic
Peter Korsgaard - May 14, 2013, 3:22 p.m.
>>>>> "Sonic" == Sonic Zhang <sonic.adi@gmail.com> writes:

 >> Could you point to specific problems with this toolchain, or give a
 >> more precise commit log?
 >> 

 Sonic> ADI officially supports the buildroot and related GNU toolchain for
 Sonic> Blackfin since ADI's 2012R1 release only. In order to avoid confusion,
 Sonic> it is better to remove the 2011R1 GNU toolchain for Blackfin. In
 Sonic> addition, the 2011R1 GNU toolchain for Blackfin doesn't support the
 Sonic> BF60x processors.

Thanks. Could you add that info to the commit message, please?

Patch

diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in
index 6cf29aa..3c6766c 100644
--- a/toolchain/toolchain-external/Config.in
+++ b/toolchain/toolchain-external/Config.in
@@ -614,23 +614,6 @@  config BR2_TOOLCHAIN_EXTERNAL_BLACKFI_UCLINUX_2012R1
 	  Toolchain for the Blackfin architecture, from
 	  http://blackfin.uclinux.org.
 
-config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2011R1
-	bool "Blackfin.uclinux.org 2011R1-RC4"
-	depends on BR2_bfin
-	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
-	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
-	select BR2_INSTALL_LIBSTDCPP
-	select BR2_LARGEFILE
-	select BR2_INET_IPV6
-	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
-	select BR2_USE_WCHAR
-	select BR2_TOOLCHAIN_HAS_THREADS
-	select BR2_TOOLCHAIN_HAS_THREADS_DEBUG
-	select BR2_HOSTARCH_NEEDS_IA32_LIBS
-	help
-	  Toolchain for the Blackfin architecture, from
-	  http://blackfin.uclinux.org.
-
 config BR2_TOOLCHAIN_EXTERNAL_XILINX_MICROBLAZEEL_V2
 	bool "Xilinx Little Endian Microblaze GNU Tools"
 	depends on BR2_microblazeel
@@ -758,8 +741,6 @@  config BR2_TOOLCHAIN_EXTERNAL_PREFIX
 	default "i686-pc-linux-gnu"	 if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201109
 	default "i686-pc-linux-gnu"	 if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201203
 	default "i686-pc-linux-gnu"	 if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201209
-	default "bfin-uclinux"		 if BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2011R1 && BR2_BINFMT_FLAT
-	default "bfin-linux-uclibc"	 if BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2011R1 && BR2_BINFMT_FDPIC
 	default "bfin-uclinux"		 if BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1 && BR2_BINFMT_FLAT
 	default "bfin-linux-uclibc"	 if BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1 && BR2_BINFMT_FDPIC
 	default "bfin-uclinux"		 if BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 && BR2_BINFMT_FLAT
diff --git a/toolchain/toolchain-external/ext-tool.mk b/toolchain/toolchain-external/ext-tool.mk
index 01578d2..b69d9bb 100644
--- a/toolchain/toolchain-external/ext-tool.mk
+++ b/toolchain/toolchain-external/ext-tool.mk
@@ -260,12 +260,6 @@  TOOLCHAIN_EXTERNAL_SOURCE=ia32-2012.03-27-i686-pc-linux-gnu-i386-linux.tar.bz2
 else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201209),y)
 TOOLCHAIN_EXTERNAL_SITE=https://sourcery.mentor.com/public/gnu_toolchain/i686-pc-linux-gnu/
 TOOLCHAIN_EXTERNAL_SOURCE=ia32-2012.09-62-i686-pc-linux-gnu-i386-linux.tar.bz2
-else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2011R1),y)
-TOOLCHAIN_EXTERNAL_SITE_1   = http://blackfin.uclinux.org/gf/download/frsrelease/531/9509/
-TOOLCHAIN_EXTERNAL_SOURCE_1 = blackfin-toolchain-2011R1-RC4.i386.tar.bz2
-TOOLCHAIN_EXTERNAL_SITE_2   = http://blackfin.uclinux.org/gf/download/frsrelease/531/9517/
-TOOLCHAIN_EXTERNAL_SOURCE_2 = blackfin-toolchain-uclibc-full-2011R1-RC4.i386.tar.bz2
-TOOLCHAIN_EXTERNAL_SOURCE   = $(TOOLCHAIN_EXTERNAL_SOURCE_1) $(TOOLCHAIN_EXTERNAL_SOURCE_2)
 else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1),y)
 TOOLCHAIN_EXTERNAL_SITE_1   = http://blackfin.uclinux.org/gf/download/frsrelease/559/9858/
 TOOLCHAIN_EXTERNAL_SOURCE_1 = blackfin-toolchain-2012R1-RC2.i386.tar.bz2
@@ -311,7 +305,7 @@  endif
 # contain ./opt/uClinux/{bfin-uclinux,bfin-linux-uclibc} directories,
 # which themselves contain the toolchain. This is why we strip more
 # components than usual.
-ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2011R1)$(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1)$(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2),y)
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1)$(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2),y)
 $(DL_DIR)/$(TOOLCHAIN_EXTERNAL_SOURCE_1):
 	$(call DOWNLOAD,$(TOOLCHAIN_EXTERNAL_SITE_1)/$(TOOLCHAIN_EXTERNAL_SOURCE_1))