Patchwork [2/2] UBUNTU: (build) Abort build on unresolved symbols

login
register
mail settings
Submitter Stefan Bader
Date April 9, 2013, 5:18 p.m.
Message ID <1365527926-7734-3-git-send-email-stefan.bader@canonical.com>
Download mbox | patch
Permalink /patch/235146/
State New
Headers show

Comments

Stefan Bader - April 9, 2013, 5:18 p.m.
When splitting the flavours of a module into the extras and base
package, we already run depmod. Unfortunately this only produces
warnings when modules in the base package have unresolved depen-
dencies.
This change will abort the build in that case, so we can fix things.

BugLink: http://bugs.launchpad.net/bugs/1166197

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
---
 debian/rules.d/2-binary-arch.mk |    4 ++++
 1 file changed, 4 insertions(+)
Tim Gardner - April 9, 2013, 6:14 p.m.

Patch

diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
index 30a163c..0529786 100644
--- a/debian/rules.d/2-binary-arch.mk
+++ b/debian/rules.d/2-binary-arch.mk
@@ -127,6 +127,10 @@  ifeq ($(do_extras_package),true)
 				tee $(target_flavour).inclusion-list.log; \
 		/sbin/depmod -b $(pkgdir) -ea -F $(pkgdir)/boot/System.map-$(abi_release)-$* \
 			$(abi_release)-$* 2>&1 |tee $(target_flavour).depmod.log; \
+		if [ `grep -c 'unknown symbol' $(target_flavour).depmod.log` -gt 0 ]; then \
+			echo "EE: Unresolved module dependencies in base package!"; \
+			exit 1; \
+		fi \
 	fi
 endif