From patchwork Tue Apr 9 13:47:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Borkmann X-Patchwork-Id: 235085 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9FC692C00C0 for ; Tue, 9 Apr 2013 23:47:25 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936026Ab3DINrX (ORCPT ); Tue, 9 Apr 2013 09:47:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24893 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761303Ab3DINrW (ORCPT ); Tue, 9 Apr 2013 09:47:22 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r39DlKq4003017 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 9 Apr 2013 09:47:20 -0400 Received: from localhost (vpn1-6-196.ams2.redhat.com [10.36.6.196]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r39DlJa3014055; Tue, 9 Apr 2013 09:47:19 -0400 From: Daniel Borkmann To: davem@davemloft.net Cc: netdev@vger.kernel.org, hannes@stressinduktion.org Subject: [PATCH net-next 1/3] net: ipv6: minor: use in6addr_any in token init Date: Tue, 9 Apr 2013 15:47:14 +0200 Message-Id: <1365515236-7154-2-git-send-email-dborkman@redhat.com> In-Reply-To: <1365515236-7154-1-git-send-email-dborkman@redhat.com> References: <1365515236-7154-1-git-send-email-dborkman@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Since we check for !ipv6_addr_any(&in6_dev->token) in addrconf_prefix_rcv(), make the token initialization on device setup more intuitive by using in6addr_any as an initializer. Suggested-by: Hannes Frederic Sowa Signed-off-by: Daniel Borkmann Acked-by: Hannes Frederic Sowa --- net/ipv6/addrconf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 65d8139..645bf31 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -422,7 +422,7 @@ static struct inet6_dev *ipv6_add_dev(struct net_device *dev) ipv6_regen_rndid((unsigned long) ndev); } #endif - memset(ndev->token.s6_addr, 0, sizeof(ndev->token.s6_addr)); + ndev->token = in6addr_any; if (netif_running(dev) && addrconf_qdisc_ok(dev)) ndev->if_flags |= IF_READY;