Patchwork [1/2] llc: fix non-const printk warning

login
register
mail settings
Submitter stephen hemminger
Date Feb. 20, 2009, 6:02 p.m.
Message ID <20090220100206.533d59d4@extreme>
Download mbox | patch
Permalink /patch/23503/
State Accepted
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Feb. 20, 2009, 6:02 p.m.
Mark some strings as const.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Arnaldo Carvalho de Melo - Feb. 20, 2009, 9:37 p.m.
Em Fri, Feb 20, 2009 at 10:02:06AM -0800, Stephen Hemminger escreveu:
> Mark some strings as const.
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Thanks,

Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>

> 
> --- a/net/llc/af_llc.c	2009-02-20 08:34:21.537870609 -0800
> +++ b/net/llc/af_llc.c	2009-02-20 08:37:52.920622312 -0800
> @@ -1118,11 +1118,11 @@ static const struct proto_ops llc_ui_ops
>  	.sendpage    = sock_no_sendpage,
>  };
>  
> -static char llc_proc_err_msg[] __initdata =
> +static const char llc_proc_err_msg[] __initconst =
>  	KERN_CRIT "LLC: Unable to register the proc_fs entries\n";
> -static char llc_sysctl_err_msg[] __initdata =
> +static const char llc_sysctl_err_msg[] __initconst =
>  	KERN_CRIT "LLC: Unable to register the sysctl entries\n";
> -static char llc_sock_err_msg[] __initdata =
> +static const char llc_sock_err_msg[] __initconst =
>  	KERN_CRIT "LLC: Unable to register the network family\n";
>  
>  static int __init llc2_init(void)
> --
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Feb. 22, 2009, 8:02 a.m.
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Fri, 20 Feb 2009 18:37:22 -0300

> Em Fri, Feb 20, 2009 at 10:02:06AM -0800, Stephen Hemminger escreveu:
> > Mark some strings as const.
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> 
> Thanks,
> 
> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/net/llc/af_llc.c	2009-02-20 08:34:21.537870609 -0800
+++ b/net/llc/af_llc.c	2009-02-20 08:37:52.920622312 -0800
@@ -1118,11 +1118,11 @@  static const struct proto_ops llc_ui_ops
 	.sendpage    = sock_no_sendpage,
 };
 
-static char llc_proc_err_msg[] __initdata =
+static const char llc_proc_err_msg[] __initconst =
 	KERN_CRIT "LLC: Unable to register the proc_fs entries\n";
-static char llc_sysctl_err_msg[] __initdata =
+static const char llc_sysctl_err_msg[] __initconst =
 	KERN_CRIT "LLC: Unable to register the sysctl entries\n";
-static char llc_sock_err_msg[] __initdata =
+static const char llc_sock_err_msg[] __initconst =
 	KERN_CRIT "LLC: Unable to register the network family\n";
 
 static int __init llc2_init(void)