| Message ID | 1365498867-27782-19-git-send-email-lczerner@redhat.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Tue 09-04-13 11:14:27, Lukas Czerner wrote: > In commits 5f95d21fb6f2aaa52830e5b7fb405f6c71d3ab85 and > 30bc2ec9598a1b156ad75217f2e7d4560efdeeab we've reworked punch_hole > implementation and there is noting holding us back from using punch hole > on file system with bigalloc feature enabled. > > This has been tested with fsx and xfstests. Looks good. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > > Signed-off-by: Lukas Czerner <lczerner@redhat.com> > --- > fs/ext4/inode.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 0d452c1..87d6171 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -3536,11 +3536,6 @@ int ext4_punch_hole(struct file *file, loff_t offset, loff_t length) > if (!S_ISREG(inode->i_mode)) > return -EOPNOTSUPP; > > - if (EXT4_SB(sb)->s_cluster_ratio > 1) { > - /* TODO: Add support for bigalloc file systems */ > - return -EOPNOTSUPP; > - } > - > trace_ext4_punch_hole(inode, offset, length); > > /* > -- > 1.7.7.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 0d452c1..87d6171 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -3536,11 +3536,6 @@ int ext4_punch_hole(struct file *file, loff_t offset, loff_t length) if (!S_ISREG(inode->i_mode)) return -EOPNOTSUPP; - if (EXT4_SB(sb)->s_cluster_ratio > 1) { - /* TODO: Add support for bigalloc file systems */ - return -EOPNOTSUPP; - } - trace_ext4_punch_hole(inode, offset, length); /*
In commits 5f95d21fb6f2aaa52830e5b7fb405f6c71d3ab85 and 30bc2ec9598a1b156ad75217f2e7d4560efdeeab we've reworked punch_hole implementation and there is noting holding us back from using punch hole on file system with bigalloc feature enabled. This has been tested with fsx and xfstests. Signed-off-by: Lukas Czerner <lczerner@redhat.com> --- fs/ext4/inode.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)