| Message ID | 1365456754-29373-5-git-send-email-jack@suse.cz |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Mon, Apr 08, 2013 at 11:32:09PM +0200, Jan Kara wrote: > Remove unused t_cow_tid field (ext4 copy-on-write support doesn't seem > to be happening) and change b_modified and b_jlist to bitfields thus > saving 8 bytes in the structure. > > Signed-off-by: Jan Kara <jack@suse.cz> Reviewed-by: Zheng Liu <wenqing.lz@taobao.com> Regards, - Zheng > --- > include/linux/journal-head.h | 11 ++--------- > 1 files changed, 2 insertions(+), 9 deletions(-) > > diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h > index c18b46f..13a3da2 100644 > --- a/include/linux/journal-head.h > +++ b/include/linux/journal-head.h > @@ -31,21 +31,14 @@ struct journal_head { > /* > * Journalling list for this buffer [jbd_lock_bh_state()] > */ > - unsigned b_jlist; > + unsigned b_jlist:4; > > /* > * This flag signals the buffer has been modified by > * the currently running transaction > * [jbd_lock_bh_state()] > */ > - unsigned b_modified; > - > - /* > - * This feild tracks the last transaction id in which this buffer > - * has been cowed > - * [jbd_lock_bh_state()] > - */ > - tid_t b_cow_tid; > + unsigned b_modified:1; > > /* > * Copy of the buffer data frozen for writing to the log. > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Apr 08, 2013 at 11:32:09PM +0200, Jan Kara wrote: > Remove unused t_cow_tid field (ext4 copy-on-write support doesn't seem > to be happening) and change b_modified and b_jlist to bitfields thus > saving 8 bytes in the structure. > > Signed-off-by: Jan Kara <jack@suse.cz> Applied for testing in the ext4 dev branch. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h index c18b46f..13a3da2 100644 --- a/include/linux/journal-head.h +++ b/include/linux/journal-head.h @@ -31,21 +31,14 @@ struct journal_head { /* * Journalling list for this buffer [jbd_lock_bh_state()] */ - unsigned b_jlist; + unsigned b_jlist:4; /* * This flag signals the buffer has been modified by * the currently running transaction * [jbd_lock_bh_state()] */ - unsigned b_modified; - - /* - * This feild tracks the last transaction id in which this buffer - * has been cowed - * [jbd_lock_bh_state()] - */ - tid_t b_cow_tid; + unsigned b_modified:1; /* * Copy of the buffer data frozen for writing to the log.
Remove unused t_cow_tid field (ext4 copy-on-write support doesn't seem to be happening) and change b_modified and b_jlist to bitfields thus saving 8 bytes in the structure. Signed-off-by: Jan Kara <jack@suse.cz> --- include/linux/journal-head.h | 11 ++--------- 1 files changed, 2 insertions(+), 9 deletions(-)