Patchwork [net-next] net: cdc_ncm: demote "unexpected notification" to debug level

login
register
mail settings
Submitter Bjørn Mork
Date April 8, 2013, 6:26 p.m.
Message ID <1365445583-15124-1-git-send-email-bjorn@mork.no>
Download mbox | patch
Permalink /patch/234860/
State Accepted
Delegated to: David Miller
Headers show

Comments

Bjørn Mork - April 8, 2013, 6:26 p.m.
Receiving unhandled notifications is most certainly not an error
and should not be logged as one.  Knowing that the device sends
notifications we don't handle is useful for developers, but there
is very little a user can do about this.  The message is therefore
just annoying noise to most users with devices sending unhandled
notifications like e.g. USB_CDC_NOTIFY_RESPONSE_AVAILABLE

Cc: Alexey Orishko <alexey.orishko@stericsson.com>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
 drivers/net/usb/cdc_ncm.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
David Miller - April 8, 2013, 8:58 p.m.
From: Bjørn Mork <bjorn@mork.no>
Date: Mon,  8 Apr 2013 20:26:23 +0200

> Receiving unhandled notifications is most certainly not an error
> and should not be logged as one.  Knowing that the device sends
> notifications we don't handle is useful for developers, but there
> is very little a user can do about this.  The message is therefore
> just annoying noise to most users with devices sending unhandled
> notifications like e.g. USB_CDC_NOTIFY_RESPONSE_AVAILABLE
> 
> Cc: Alexey Orishko <alexey.orishko@stericsson.com>
> Signed-off-by: Bjørn Mork <bjorn@mork.no>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 44a989c..67012cb 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -1124,8 +1124,9 @@  static void cdc_ncm_status(struct usbnet *dev, struct urb *urb)
 		break;
 
 	default:
-		dev_err(&dev->udev->dev, "NCM: unexpected "
-			"notification 0x%02x!\n", event->bNotificationType);
+		dev_dbg(&dev->udev->dev,
+			"NCM: unexpected notification 0x%02x!\n",
+			event->bNotificationType);
 		break;
 	}
 }