Patchwork [v2,2/3] post-image: show each script filename before execution

login
register
mail settings
Submitter Luca Ceresoli
Date April 8, 2013, 4:50 p.m.
Message ID <1365439816-6935-3-git-send-email-luca@lucaceresoli.net>
Download mbox | patch
Permalink /patch/234843/
State Accepted
Commit 6d90a69f6c58caff17c1de2f000b65f9bc5a9077
Headers show

Comments

Luca Ceresoli - April 8, 2013, 4:50 p.m.
This also simplifies code by removing the ifneq/endif clauses.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 Makefile |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Yann E. MORIN - April 16, 2013, 9:50 p.m.
Luca, All,

On Mon, Apr 08, 2013 at 06:50:15PM +0200, Luca Ceresoli wrote:
> This also simplifies code by removing the ifneq/endif clauses.
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.
Peter Korsgaard - April 24, 2013, 8:16 p.m.
>>>>> "Luca" == Luca Ceresoli <luca@lucaceresoli.net> writes:

 Luca> This also simplifies code by removing the ifneq/endif clauses.

Committed, thanks.
Arnout Vandecappelle - April 30, 2013, 4:58 p.m.
On 08/04/13 18:50, Luca Ceresoli wrote:
> This also simplifies code by removing the ifneq/endif clauses.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

> ---
>   Makefile |    4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 75f0f0c..f475d1b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -555,11 +555,9 @@ target-generatelocales: host-localedef
>   endif
>
>   target-post-image:
> -ifneq ($(BR2_ROOTFS_POST_IMAGE_SCRIPT),"")
> -	@$(call MESSAGE,"Executing post-image script\(s\)")
>   	@$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_IMAGE_SCRIPT)), \
> +		$(call MESSAGE,"Executing post-image script $(s)"); \
>   		$(s) $(BINARIES_DIR)$(sep))
> -endif
>
>   toolchain-eclipse-register:
>   	./support/scripts/eclipse-register-toolchain `readlink -f $(O)` $(notdir $(TARGET_CROSS)) $(BR2_ARCH)
>

Patch

diff --git a/Makefile b/Makefile
index 75f0f0c..f475d1b 100644
--- a/Makefile
+++ b/Makefile
@@ -555,11 +555,9 @@  target-generatelocales: host-localedef
 endif
 
 target-post-image:
-ifneq ($(BR2_ROOTFS_POST_IMAGE_SCRIPT),"")
-	@$(call MESSAGE,"Executing post-image script\(s\)")
 	@$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_IMAGE_SCRIPT)), \
+		$(call MESSAGE,"Executing post-image script $(s)"); \
 		$(s) $(BINARIES_DIR)$(sep))
-endif
 
 toolchain-eclipse-register:
 	./support/scripts/eclipse-register-toolchain `readlink -f $(O)` $(notdir $(TARGET_CROSS)) $(BR2_ARCH)