From patchwork Mon Apr 8 16:50:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Ceresoli X-Patchwork-Id: 234842 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 92E5B2C00A2 for ; Tue, 9 Apr 2013 02:51:04 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 25992318D0; Mon, 8 Apr 2013 16:51:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RQMQSjmIW0oR; Mon, 8 Apr 2013 16:50:57 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 19F1E318D3; Mon, 8 Apr 2013 16:50:49 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 4F5B68F75E for ; Mon, 8 Apr 2013 16:50:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id AD6FA89C7F for ; Mon, 8 Apr 2013 16:50:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MUnu7nzeopxD for ; Mon, 8 Apr 2013 16:50:33 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from m-14.th.seeweb.it (m-14.th.seeweb.it [217.64.195.243]) by whitealder.osuosl.org (Postfix) with ESMTPS id BCDC089C30 for ; Mon, 8 Apr 2013 16:50:32 +0000 (UTC) Received: from wallace.comelit.it (host138-62-static.18-80-b.business.telecomitalia.it [80.18.62.138]) (authenticated bits=0) by m-14.th.seeweb.it (8.14.3/8.14.3/Debian-9.4) with ESMTP id r38GoNfS032165; Mon, 8 Apr 2013 18:50:30 +0200 From: Luca Ceresoli To: buildroot@busybox.net Date: Mon, 8 Apr 2013 18:50:16 +0200 Message-Id: <1365439816-6935-4-git-send-email-luca@lucaceresoli.net> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1365439816-6935-1-git-send-email-luca@lucaceresoli.net> References: <1365439816-6935-1-git-send-email-luca@lucaceresoli.net> Cc: thomas.petazzoni@free-electrons.com, Luca Ceresoli Subject: [Buildroot] [PATCH v2 3/3] rootfs-overlay: use a make foreach instead of a shell for X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Makes the code uniform with the post-build and post-image implementation (which is slightly simpler and, presumably, more efficient). Signed-off-by: Luca Ceresoli Reviewed-by: "Yann E. MORIN" Acked-by: Arnout Vandecappelle (Essensium/Mind) --- Makefile | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index f475d1b..a3b98f3 100644 --- a/Makefile +++ b/Makefile @@ -501,13 +501,12 @@ endif echo "PRETTY_NAME=\"Buildroot $(BR2_VERSION)\"" \ ) > $(TARGET_DIR)/etc/os-release - @for dir in $(call qstrip,$(BR2_ROOTFS_OVERLAY)); do \ - $(call MESSAGE,"Copying overlay $${dir}"); \ + @$(foreach d, $(call qstrip,$(BR2_ROOTFS_OVERLAY)), \ + $(call MESSAGE,"Copying overlay $(d)"); \ rsync -a \ --exclude .empty --exclude .svn --exclude .git \ --exclude .hg --exclude '*~' \ - $${dir}/ $(TARGET_DIR); \ - done + $(d)/ $(TARGET_DIR)$(sep)) @$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_BUILD_SCRIPT)), \ $(call MESSAGE,"Executing post-build script $(s)"); \