Patchwork [099/102] thermal: return an error on failure to register thermal class

mail settings
Submitter Luis Henriques
Date April 8, 2013, 9:50 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/234713/
State New
Headers show


Luis Henriques - April 8, 2013, 9:50 a.m. -stable review patch.  If anyone has any objections, please let me know.


From: Richard Guy Briggs <>

commit da28d966f6aa942ae836d09729f76a1647932309 upstream.

The return code from the registration of the thermal class is used to
unallocate resources, but this failure isn't passed back to the caller of
thermal_init.  Return this failure back to the caller.

This bug was introduced in changeset 4cb18728 which overwrote the return code
when the variable was re-used to catch the return code of the registration of
the genetlink thermal socket family.

Signed-off-by: Richard Guy Briggs <>
Signed-off-by: Zhang Rui <>
Signed-off-by: Luis Henriques <>
 drivers/thermal/thermal_sys.c | 1 +
 1 file changed, 1 insertion(+)


diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
index 022bacb..5c26dda 100644
--- a/drivers/thermal/thermal_sys.c
+++ b/drivers/thermal/thermal_sys.c
@@ -1383,6 +1383,7 @@  static int __init thermal_init(void)
+		return result;
 	result = genetlink_init();
 	return result;