Patchwork [01/16] atm: update msg_namelen in vcc_recvmsg()

mail settings
Submitter Mathias Krause
Date April 7, 2013, 11:51 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/234495/
State Accepted
Delegated to: David Miller
Headers show


Mathias Krause - April 7, 2013, 11:51 a.m.
The current code does not fill the msg_name member in case it is set.
It also does not set the msg_namelen member to 0 and therefore makes
net/socket.c leak the local, uninitialized sockaddr_storage variable
to userland -- 128 bytes of kernel stack memory.

Fix that by simply setting msg_namelen to 0 as obviously nobody cared
about vcc_recvmsg() not filling the msg_name in case it was set.

Signed-off-by: Mathias Krause <>
 net/atm/common.c |    2 ++
 1 file changed, 2 insertions(+)


diff --git a/net/atm/common.c b/net/atm/common.c
index 7b49100..737bef5 100644
--- a/net/atm/common.c
+++ b/net/atm/common.c
@@ -531,6 +531,8 @@  int vcc_recvmsg(struct kiocb *iocb, struct socket *sock, struct msghdr *msg,
 	struct sk_buff *skb;
 	int copied, error = -EINVAL;
+	msg->msg_namelen = 0;
 	if (sock->state != SS_CONNECTED)
 		return -ENOTCONN;