From patchwork Fri Apr 5 21:02:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathias Krause X-Patchwork-Id: 234286 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id BC91F2C0132 for ; Sat, 6 Apr 2013 08:02:44 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162225Ab3DEVCk (ORCPT ); Fri, 5 Apr 2013 17:02:40 -0400 Received: from mail-bk0-f51.google.com ([209.85.214.51]:41617 "EHLO mail-bk0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162097Ab3DEVCj (ORCPT ); Fri, 5 Apr 2013 17:02:39 -0400 Received: by mail-bk0-f51.google.com with SMTP id y8so2306324bkt.38 for ; Fri, 05 Apr 2013 14:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=OynhCLU1xMZMCHC4lGozI+BSgGj8bXfqY4nuU/+MRbc=; b=Mq3rQ9jTp1OcaXfmh/iFFi1SznISEqoH2nDHPfZZ952k5LLgCagM5W8tV6EsQUgWTS j6mdvWYnRyrUi4kty5+fKOlbnmoZkuMvBQyHgCtCVTIi6WwOHxpQBj+UsJDjJ43WDM5r oAFVby9tPehOXldLTq5bHZyk5lWz/aI9Zrwf55GdJGBGowJxxNDJwUVxWeMNAlAbeX8L mHAlsHCmboZWn8vdblPbNaZ2Ru6DlwtS/swhSC4V3FJRGKAswe/kinH9ZjsLkogWtWRJ SucWPkaBtX01vvx0MIt1xka4TTHUyGbvsJTiajDQrESTDWnTYHPl4LUBF1nsDk1yEAEr b0zw== X-Received: by 10.205.37.198 with SMTP id tf6mr7434527bkb.29.1365195758203; Fri, 05 Apr 2013 14:02:38 -0700 (PDT) Received: from jig.fritz.box (pD9EB4908.dip.t-dialin.net. [217.235.73.8]) by mx.google.com with ESMTPS id m11sm7457869bkz.0.2013.04.05.14.02.37 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 05 Apr 2013 14:02:37 -0700 (PDT) From: Mathias Krause To: Greg Kroah-Hartman Cc: Samuel Ortiz , "David S. Miller" , netdev@vger.kernel.org, Mathias Krause Subject: [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open() Date: Fri, 5 Apr 2013 23:02:07 +0200 Message-Id: <1365195727-24780-1-git-send-email-minipli@googlemail.com> X-Mailer: git-send-email 1.7.10.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Greg, I'm unsure if you or Dave should take that one as it's for one a TTY patch but also living under net/. So I'm uncertain and let you decide! Thanks, Mathias -- >8 -- Subject: [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open() We're clearly running in non-atomic context as our only call site is able to call wait_event_interruptible(). So we're safe to use GFP_KERNEL here instead of GFP_ATOMIC. Signed-off-by: Mathias Krause Acked-by: Greg Kroah-Hartman --- net/irda/ircomm/ircomm_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/irda/ircomm/ircomm_core.c b/net/irda/ircomm/ircomm_core.c index 52079f1..b797daa 100644 --- a/net/irda/ircomm/ircomm_core.c +++ b/net/irda/ircomm/ircomm_core.c @@ -117,7 +117,7 @@ struct ircomm_cb *ircomm_open(notify_t *notify, __u8 service_type, int line) IRDA_ASSERT(ircomm != NULL, return NULL;); - self = kzalloc(sizeof(struct ircomm_cb), GFP_ATOMIC); + self = kzalloc(sizeof(struct ircomm_cb), GFP_KERNEL); if (self == NULL) return NULL;